Remove EVEA compatibility path using V4L2_CID_GLOBAL_ALPHA

Remove EVEA compatibility path using V4L2_CID_GLOBAL_ALPHA

Both 3.4 and 3.8 kernels for Exynos have supported setting the GSC alpha
component through V4L2_CID_ALPHA_COMPONENT for some time now.  Remove the
V4L2_CID_GLOBAL_ALPHA workaround path.

BUG=326590
TEST=local build, run on exynos

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248590

[sheu, 2014-02-03 19:13:56]

Simple enough.  PTAL

[Ami GONE FROM CHROMIUM, 2014-02-03 19:20:20]

LGTM


On Mon, Feb 3, 2014 at 11:13 AM, <sheu@chromium.org> wrote:

> Reviewers: Ami Fischman, Pawel Osciak,
>
> Message:
> Simple enough.  PTAL
>
> Description:
> Remove EVEA compatibility path using V4L2_CID_GLOBAL_ALPHA
>
> Both 3.4 and 3.8 kernels for Exynos have supported setting the GSC alpha
> component through V4L2_CID_ALPHA_COMPONENT for some time now.  Remove the
> V4L2_CID_GLOBAL_ALPHA workaround path.
>
> BUG=326590
> TEST=local build, run on exynos
>
> Please review this at https://chromiumcodereview.appspot.com/147793006/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files (+1, -8 lines):
>   M content/common/gpu/media/exynos_video_encode_accelerator.cc
>
>
> Index: content/common/gpu/media/exynos_video_encode_accelerator.cc
> diff --git a/content/common/gpu/media/exynos_video_encode_accelerator.cc
> b/content/common/gpu/media/exynos_video_encode_accelerator.cc
> index e8a2196edc6bfdcd60cb1cfaf14dba3c9b4866c2..
> e5c3a738819785729df15d5b995cf3911215bb79 100644
> --- a/content/common/gpu/media/exynos_video_encode_accelerator.cc
> +++ b/content/common/gpu/media/exynos_video_encode_accelerator.cc
> @@ -1188,14 +1188,7 @@ bool
ExynosVideoEncodeAccelerator::CreateGscInputBuffers()
> {
>    memset(&control, 0, sizeof(control));
>    control.id    = V4L2_CID_ALPHA_COMPONENT;
>    control.value = 255;
> -  if (HANDLE_EINTR(ioctl(gsc_fd_, VIDIOC_S_CTRL, &control)) != 0) {
> -    // TODO(posciak): This is a  temporary hack and should be removed when
> -    // all platforms migrate to kernel >=3.8.
> -    memset(&control, 0, sizeof(control));
> -    control.id    = V4L2_CID_GLOBAL_ALPHA;
> -    control.value = 255;
> -    IOCTL_OR_ERROR_RETURN_FALSE(gsc_fd_, VIDIOC_S_CTRL, &control);
> -  }
> +  IOCTL_OR_ERROR_RETURN_FALSE(gsc_fd_, VIDIOC_S_CTRL, &control);
>
>    struct v4l2_format format;
>    memset(&format, 0, sizeof(format));
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[sheu, 2014-02-03 19:24:22]

The CQ bit was checked by sheu@chromium.org

[commit-bot: I haz the power, 2014-02-03 19:25:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sheu@chromium.org/147793006/1

[commit-bot: I haz the power, 2014-02-03 22:14:05]

Change committed as 248590

[commit-bot: I haz the power, 2014-02-03 22:14:10]

CQ bit was unchecked on CL. Ignoring.

[commit-bot: I haz the power, 2014-02-03 22:14:12]

CQ bit was unchecked on CL. Ignoring.