Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1477913002:
Restore paintController displayItemConstructionIsDisabled in ContentLayerDelegate::paintContents() (Closed)
|
Created:
5 years ago by Xianzhu Modified:
5 years ago CC:
blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, vmpstr+blinkwatch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRestore paintController displayItemConstructionIsDisabled in ContentLayerDelegate::paintContents()
Otherwise the flag may remain set and have inconsistent setting in
PaintController and GraphicsContext during the next sync painting,
causing crash in GraphicsContext because of null m_canvas.
TBR=chrishtr@chromium.org
BUG=536999
Committed: https://crrev.com/271c3e01e07fbbee4d3b13e20f265bcdb9fb6ddd
Cr-Commit-Position: refs/heads/master@{#361761}
Patch Set 1 #
Messages
Total messages: 20 (11 generated)
wangxianzhu@chromium.org changed reviewers: + chrishtr@chromium.org
wangxianzhu@chromium.org changed reviewers: + pdr@chromium.org
The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477913002/1
Description was changed from ========== Restore paintController displayItemConstructionIsDisabled in ContentLayerDelegate::paintContents() Otherwise the flag may remain set and inconsistent setting in PaintController and GraphicsContext during the next sync painting, causing crash in GraphicsContext because of null m_canvas. BUG=536999 ========== to ========== Restore paintController displayItemConstructionIsDisabled in ContentLayerDelegate::paintContents() Otherwise the flag may remain set and have inconsistent setting in PaintController and GraphicsContext during the next sync painting, causing crash in GraphicsContext because of null m_canvas. BUG=536999 ==========
Description was changed from ========== Restore paintController displayItemConstructionIsDisabled in ContentLayerDelegate::paintContents() Otherwise the flag may remain set and have inconsistent setting in PaintController and GraphicsContext during the next sync painting, causing crash in GraphicsContext because of null m_canvas. BUG=536999 ========== to ========== Restore paintController displayItemConstructionIsDisabled in ContentLayerDelegate::paintContents() Otherwise the flag may remain set and have inconsistent setting in PaintController and GraphicsContext during the next sync painting, causing crash in GraphicsContext because of null m_canvas. TBR=chrishtr@chromium.org BUG=536999 ==========
The CQ bit was unchecked by wangxianzhu@chromium.org
The CQ bit was checked by wangxianzhu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477913002/1
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) ios_rel_device_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by wangxianzhu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477913002/1
Message was sent while issue was closed.
Description was changed from ========== Restore paintController displayItemConstructionIsDisabled in ContentLayerDelegate::paintContents() Otherwise the flag may remain set and have inconsistent setting in PaintController and GraphicsContext during the next sync painting, causing crash in GraphicsContext because of null m_canvas. TBR=chrishtr@chromium.org BUG=536999 ========== to ========== Restore paintController displayItemConstructionIsDisabled in ContentLayerDelegate::paintContents() Otherwise the flag may remain set and have inconsistent setting in PaintController and GraphicsContext during the next sync painting, causing crash in GraphicsContext because of null m_canvas. TBR=chrishtr@chromium.org BUG=536999 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Restore paintController displayItemConstructionIsDisabled in ContentLayerDelegate::paintContents() Otherwise the flag may remain set and have inconsistent setting in PaintController and GraphicsContext during the next sync painting, causing crash in GraphicsContext because of null m_canvas. TBR=chrishtr@chromium.org BUG=536999 ========== to ========== Restore paintController displayItemConstructionIsDisabled in ContentLayerDelegate::paintContents() Otherwise the flag may remain set and have inconsistent setting in PaintController and GraphicsContext during the next sync painting, causing crash in GraphicsContext because of null m_canvas. TBR=chrishtr@chromium.org BUG=536999 Committed: https://crrev.com/271c3e01e07fbbee4d3b13e20f265bcdb9fb6ddd Cr-Commit-Position: refs/heads/master@{#361761} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/271c3e01e07fbbee4d3b13e20f265bcdb9fb6ddd Cr-Commit-Position: refs/heads/master@{#361761} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
