tests_lit/assembler/arm32/bic.ll - Issue 1477873002: Subzero. ARM32. Folding rematerializable offsets in address operands.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tests_lit/assembler/arm32/bic.ll

Issue 1477873002: Subzero. ARM32. Folding rematerializable offsets in address operands. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Reverts lit test change Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 ; Show that we know how to translate bic.	1 ; Show that we know how to translate bic.

2	2

3 ; NOTE: We use -O2 to get rid of memory stores.	3 ; NOTE: We use -O2 to get rid of memory stores.

4	4

5 ; REQUIRES: allow_dump	5 ; REQUIRES: allow_dump

6	6

7 ; Compile using standalone assembler.	7 ; Compile using standalone assembler.

8 ; RUN: %p2i --filetype=asm -i %s --target=arm32 --args -O2 \	8 ; RUN: %p2i --filetype=asm -i %s --target=arm32 --args -O2 \

9 ; RUN: \| FileCheck %s --check-prefix=ASM	9 ; RUN: \| FileCheck %s --check-prefix=ASM

10	10

(...skipping 44 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
55	55

56 ; ASM-NEXT: bic sp, sp, #31	56 ; ASM-NEXT: bic sp, sp, #31

57 ; DIS-NEXT: c: e3cdd01f	57 ; DIS-NEXT: c: e3cdd01f

58 ; IASM: .byte 0x1f	58 ; IASM: .byte 0x1f

59 ; IASM-NEXT: .byte 0xd0	59 ; IASM-NEXT: .byte 0xd0

60 ; IASM-NEXT: .byte 0xcd	60 ; IASM-NEXT: .byte 0xcd

61 ; IASM-NEXT: .byte 0xe3	61 ; IASM-NEXT: .byte 0xe3

62	62

63 ; ASM-NEXT: # sp = def.pseudo	63 ; ASM-NEXT: # sp = def.pseudo

64	64

65 ; ASM-NEXT: add r0, sp, #0	65 ; ASM-NEXT: sub r0, sp, #0
	Jim Stichnoth 2015/12/03 16:44:33 I realize there's probably no architectural differ I realize there's probably no architectural difference, but I'm much happier seeing an add of 0 instead of a subtract of 0 in this situation. I'm not sure how this particular diff came about, but would it be practical to change it? John 2015/12/03 17:06:53 Done. Show quoted text On 2015/12/03 16:44:33, stichnot wrote: > I realize there's probably no architectural difference, but I'm much happier > seeing an add of 0 instead of a subtract of 0 in this situation. I'm not sure > how this particular diff came about, but would it be practical to change it? Done.
66 ; DIS-NEXT: 10: e28d0000	66 ; DIS-NEXT: 10: e24d0000

67 ; IASM: .byte 0x0	67 ; IASM: .byte 0x0

68 ; IASM-NEXT: .byte 0x0	68 ; IASM-NEXT: .byte 0x0

69 ; IASM-NEXT: .byte 0x8d	69 ; IASM-NEXT: .byte 0x4d

70 ; IASM-NEXT: .byte 0xe2	70 ; IASM-NEXT: .byte 0xe2

71	71

72 ; ASM-NEXT: mov sp, fp	72 ; ASM-NEXT: mov sp, fp

73 ; DIS-NEXT: 14: e1a0d00b	73 ; DIS-NEXT: 14: e1a0d00b

74 ; IASM: .byte 0xb	74 ; IASM: .byte 0xb

75 ; IASM-NEXT: .byte 0xd0	75 ; IASM-NEXT: .byte 0xd0

76 ; IASM-NEXT: .byte 0xa0	76 ; IASM-NEXT: .byte 0xa0

77 ; IASM-NEXT: .byte 0xe1	77 ; IASM-NEXT: .byte 0xe1

78	78

79 ; ASM-NEXT: pop {fp}	79 ; ASM-NEXT: pop {fp}

80 ; DIS-NEXT: 18: e49db004	80 ; DIS-NEXT: 18: e49db004

81 ; IASM-NEXT: .byte 0x4	81 ; IASM-NEXT: .byte 0x4

82 ; IASM-NEXT: .byte 0xb0	82 ; IASM-NEXT: .byte 0xb0

83 ; IASM-NEXT: .byte 0x9d	83 ; IASM-NEXT: .byte 0x9d

84 ; IASM-NEXT: .byte 0xe4	84 ; IASM-NEXT: .byte 0xe4

85	85

86 ; ASM-NEXT: # fp = def.pseudo	86 ; ASM-NEXT: # fp = def.pseudo

87	87

88 ; ASM-NEXT: bx lr	88 ; ASM-NEXT: bx lr

89 ; DIS-NEXT: 1c: e12fff1e	89 ; DIS-NEXT: 1c: e12fff1e

90 ; IASM: .byte 0x1e	90 ; IASM: .byte 0x1e

91 ; IASM-NEXT: .byte 0xff	91 ; IASM-NEXT: .byte 0xff

92 ; IASM-NEXT: .byte 0x2f	92 ; IASM-NEXT: .byte 0x2f

93 ; IASM-NEXT: .byte 0xe1	93 ; IASM-NEXT: .byte 0xe1

OLD	NEW

« src/IceTargetLoweringARM32.h ('K') | « src/IceTargetLoweringARM32.cpp ('k') | no next file » | no next file with comments »