Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 1477803002: [turbofan] Generalize representation inference for NumberAdd. (Closed)

Created:
5 years ago by Jarin
Modified:
5 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, danno
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Generalize representation inference for NumberAdd. This should fix the Turbofan Octane/Mandreel regression introduced by commit 9ea551aa450f818540bcc47445f9ea6be8f32ab8 Author: jarin <jarin@chromium.org>; Date: Sun Nov 22 05:45:38 2015 -0800 [turbofan] Simplify lowering of number addition. Review URL: https://codereview.chromium.org/1471533002 Cr-Commit-Position: refs/heads/master@{#32159} Committed: https://crrev.com/d5e5e1e16161a7e5bf57ab3c2c16ba0839c414ed Cr-Commit-Position: refs/heads/master@{#32304}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M src/compiler/simplified-lowering.cc View 2 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jarin
Could you take a look, please?
5 years ago (2015-11-25 15:20:34 UTC) #2
Benedikt Meurer
LGTM.
5 years ago (2015-11-25 16:56:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477803002/1
5 years ago (2015-11-25 19:13:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 20:10:12 UTC) #6
commit-bot: I haz the power
5 years ago (2015-11-25 20:10:29 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d5e5e1e16161a7e5bf57ab3c2c16ba0839c414ed
Cr-Commit-Position: refs/heads/master@{#32304}

Powered by Google App Engine
This is Rietveld 408576698