Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 1477793002: [tools/perf] Add smoke test cover for record_wpr list command (Closed)

Created:
5 years ago by nednguyen
Modified:
5 years ago
Reviewers:
perezju
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tools/perf] Add smoke test cover for record_wpr list command This should catch the breakage which https://codereview.chromium.org/1476783002/ fixes. BUG=561431 Committed: https://crrev.com/f1f30e79215858247293e6006e1f53b3b8d84209 Cr-Commit-Position: refs/heads/master@{#361702}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M tools/perf/scripts_smoke_unittest.py View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
nednguyen
5 years ago (2015-11-25 14:49:15 UTC) #2
perezju
lgtm thanks!
5 years ago (2015-11-25 15:10:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477793002/1
5 years ago (2015-11-25 17:13:07 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 18:26:14 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f1f30e79215858247293e6006e1f53b3b8d84209 Cr-Commit-Position: refs/heads/master@{#361702}
5 years ago (2015-11-25 18:27:34 UTC) #10
brucedawson
5 years ago (2015-11-25 19:32:11 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1479623002/ by brucedawson@chromium.org.

The reason for reverting is: Failure in android_tests_dbg,
self.assertIn('kraken', stdout)
  AssertionError: 'kraken' not found in

https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20(dbg)/...

(bruce the sheriff).

Powered by Google App Engine
This is Rietveld 408576698