Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 1477783003: [Interpreter] Deprecate bytecode-graph-builder-unittest. (Closed)

Created:
5 years ago by oth
Modified:
5 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, Michael Starzinger, mvstanton, mythria, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Deprecate bytecode-graph-builder-unittest. Removing bytecode graph builder tests as they are high maintenance and have limited use, ie they track changes in the implementation rather than behaviour. BUG=v8:4280 LOG=N Committed: https://crrev.com/c0bc19fc7f2c13a4806ce2a7dca14aea90b18e6b Cr-Commit-Position: refs/heads/master@{#32333}

Patch Set 1 #

Patch Set 2 : Additional clean up. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1395 lines) Patch
D test/unittests/compiler/bytecode-graph-builder-unittest.cc View 1 chunk +0 lines, -812 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 1 chunk +0 lines, -47 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 1 2 chunks +0 lines, -535 lines 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
oth
Benedikt: PTAL. Ross: the individuals on the cc list and I discussed the overhead and ...
5 years ago (2015-11-26 10:56:15 UTC) #2
Benedikt Meurer
Nice, thanks. LGTM!
5 years ago (2015-11-26 11:12:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477783003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477783003/20001
5 years ago (2015-11-26 11:33:29 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-26 11:49:52 UTC) #6
commit-bot: I haz the power
5 years ago (2015-11-26 11:50:25 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c0bc19fc7f2c13a4806ce2a7dca14aea90b18e6b
Cr-Commit-Position: refs/heads/master@{#32333}

Powered by Google App Engine
This is Rietveld 408576698