Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: printing/printing_context_android.cc

Issue 1477783002: jni: Pass method parameters as JavaParamRef in printing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « printing/printing_context_android.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: printing/printing_context_android.cc
diff --git a/printing/printing_context_android.cc b/printing/printing_context_android.cc
index c524883bf36e12364350525aa0618f947ca86e37..aa9742af8aff0447ac6dbfb847b97725d77959c4 100644
--- a/printing/printing_context_android.cc
+++ b/printing/printing_context_android.cc
@@ -103,9 +103,10 @@ void PrintingContextAndroid::AskUserForSettings(
}
}
-void PrintingContextAndroid::AskUserForSettingsReply(JNIEnv* env,
- jobject obj,
- jboolean success) {
+void PrintingContextAndroid::AskUserForSettingsReply(
+ JNIEnv* env,
+ const JavaParamRef<jobject>& obj,
+ jboolean success) {
if (!success) {
// TODO(cimamoglu): Differentiate between FAILED And CANCEL.
callback_.Run(FAILED);
@@ -137,8 +138,9 @@ void PrintingContextAndroid::AskUserForSettingsReply(JNIEnv* env,
callback_.Run(OK);
}
-void PrintingContextAndroid::ShowSystemDialogDone(JNIEnv* env,
- jobject obj) {
+void PrintingContextAndroid::ShowSystemDialogDone(
+ JNIEnv* env,
+ const JavaParamRef<jobject>& obj) {
// Settings are not updated, callback is called only to unblock javascript.
callback_.Run(CANCEL);
}
« no previous file with comments | « printing/printing_context_android.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698