Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1477783002: jni: Pass method parameters as JavaParamRef in printing. (Closed)

Created:
5 years ago by Torne
Modified:
5 years ago
Reviewers:
whywhat
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

jni: Pass method parameters as JavaParamRef in printing. Pass all object parameters to JNI methods in JavaParamRef<> wrappers. This matches previous changes made to do this for JNI non-method functions. BUG=519562 R=avayvod@chromium.org Committed: https://crrev.com/6f3f097a5b4e7a7272b27ca6049222bb4858c104 Cr-Commit-Position: refs/heads/master@{#361696}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M printing/printing_context_android.h View 1 chunk +5 lines, -2 lines 0 comments Download
M printing/printing_context_android.cc View 2 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Torne
5 years ago (2015-11-25 14:08:48 UTC) #1
whywhat
lgtm
5 years ago (2015-11-25 14:53:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477783002/1
5 years ago (2015-11-25 14:53:38 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 18:04:37 UTC) #5
commit-bot: I haz the power
5 years ago (2015-11-25 18:05:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6f3f097a5b4e7a7272b27ca6049222bb4858c104
Cr-Commit-Position: refs/heads/master@{#361696}

Powered by Google App Engine
This is Rietveld 408576698