chrome/browser/resources/settings/settings_page/settings_page_visibility.html - Issue 1477773003: Use dom-if to hide settings pages and show explicitly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_page/settings_page_visibility.html

Issue 1477773003: Use dom-if to hide settings pages and show explicitly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/settings_page/compiled_resources.gyp ('k') | chrome/browser/resources/settings/settings_page/settings_page_visibility.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/settings_page/settings_page_visibility.html

diff --git a/third_party/WebKit/LayoutTests/fast/forms/disabled-search-input-expected.txt b/chrome/browser/resources/settings/settings_page/settings_page_visibility.html

similarity index 69%

copy from third_party/WebKit/LayoutTests/fast/forms/disabled-search-input-expected.txt

copy to chrome/browser/resources/settings/settings_page/settings_page_visibility.html

index f5175ab409c133a08ec180fd2e78b4f18330d9cc..8a40c5edd7bf1680a94331905d0dded5799b8c8c 100644

--- a/third_party/WebKit/LayoutTests/fast/forms/disabled-search-input-expected.txt

+++ b/chrome/browser/resources/settings/settings_page/settings_page_visibility.html

@@ -1,2 +1 @@

-The inner text element of the search input should never be 0-height: PASS

+<script src="settings_page_visibility.js"></script>