chrome/browser/resources/settings/advanced_page/advanced_page.js - Issue 1477773003: Use dom-if to hide settings pages and show explicitly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/advanced_page/advanced_page.js

Issue 1477773003: Use dom-if to hide settings pages and show explicitly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/advanced_page/advanced_page.html ('k') | chrome/browser/resources/settings/advanced_page/compiled_resources.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/advanced_page/advanced_page.js

diff --git a/chrome/browser/resources/settings/advanced_page/advanced_page.js b/chrome/browser/resources/settings/advanced_page/advanced_page.js

index 6af31ccc55ae1707d7a6edeb94950364286cd34d..d99fd460df0a35351929895bcc627d8627309c5a 100644

--- a/chrome/browser/resources/settings/advanced_page/advanced_page.js

+++ b/chrome/browser/resources/settings/advanced_page/advanced_page.js

@@ -37,10 +37,15 @@ Polymer({

type: Object,

notify: true,

- },

- ready: function() {

- this.$.locationCategory.category =

- settings.ContentSettingsTypes.GEOLOCATION;

+ /**

+ * The site-settings-category type for the location page.

+ */

+ locationCategory: {

+ type: Number,

+ value: settings.ContentSettingsTypes.GEOLOCATION,

+ },

+ behaviors: [SettingsPageVisibility],

});