Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4752)

Unified Diff: chrome/browser/resources/settings/controls/settings_checkbox.js

Issue 1477773003: Use dom-if to hide settings pages and show explicitly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/controls/settings_checkbox.js
diff --git a/chrome/browser/resources/settings/controls/settings_checkbox.js b/chrome/browser/resources/settings/controls/settings_checkbox.js
index e892fb96f4558da4cc6a74c347366da705ffc505..b89ab74d596fae6ca264d4cd947a6a47e2fb5981 100644
--- a/chrome/browser/resources/settings/controls/settings_checkbox.js
+++ b/chrome/browser/resources/settings/controls/settings_checkbox.js
@@ -87,7 +87,12 @@ Polymer({
* @private
*/
checkedChanged_: function() {
- this.set('pref.value', this.getNewValue_(this.checked));
+ if (!this.pref)
+ return;
+ var newvalue = this.getNewValue_(this.checked);
+ if (this.pref.type == chrome.settingsPrivate.PrefType.NUMBER)
+ newvalue = newvalue ? 1 : 0;
+ this.set('pref.value', newvalue);
},
/**

Powered by Google App Engine
This is Rietveld 408576698