Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3830)

Unified Diff: chrome/browser/resources/settings/basic_page/basic_page.js

Issue 1477773003: Use dom-if to hide settings pages and show explicitly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/basic_page/basic_page.js
diff --git a/chrome/browser/resources/settings/basic_page/basic_page.js b/chrome/browser/resources/settings/basic_page/basic_page.js
index c23e61b0816709f546f8ea488cbd9c5421de0173..5efad87ac163d801a4040cf5a99d6865ed26fa9b 100644
--- a/chrome/browser/resources/settings/basic_page/basic_page.js
+++ b/chrome/browser/resources/settings/basic_page/basic_page.js
@@ -36,4 +36,20 @@ Polymer({
notify: true,
},
},
+
+ behaviors: [SettingsPageVisibility],
+
+ ready: function() {
+ if (this.pageVisible == undefined) {
+ this.setVisiblePages([
Dan Beam 2015/11/30 19:22:43 why do we need this? why can't the behavior calcu
stevenjb 2015/11/30 20:32:47 Sorry, I don't understand your comment. The inten
+ 'people',
+ 'internet',
+ 'appearance',
+ 'onStartup',
+ 'search',
+ 'users',
+ 'defaultBrowser'
+ ]);
+ }
+ }
});

Powered by Google App Engine
This is Rietveld 408576698