Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: chrome/browser/resources/settings/basic_page/basic_page.html

Issue 1477773003: Use dom-if to hide settings pages and show explicitly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/resources/settings/advanced_page/compiled_resources.gyp ('k') | chrome/browser/resources/settings/basic_page/basic_page.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html"> 1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">
2 <link rel="import" href="chrome://md-settings/appearance_page/appearance_page.ht ml"> 2 <link rel="import" href="chrome://md-settings/appearance_page/appearance_page.ht ml">
3 <link rel="import" href="chrome://md-settings/search_page/search_page.html"> 3 <link rel="import" href="chrome://md-settings/search_page/search_page.html">
4 <link rel="import" href="chrome://md-settings/settings_page/settings_page_visibi lity.html">
4 <link rel="import" href="chrome://md-settings/settings_page/settings_section.htm l"> 5 <link rel="import" href="chrome://md-settings/settings_page/settings_section.htm l">
5 <link rel="import" href="chrome://md-settings/on_startup_page/on_startup_page.ht ml"> 6 <link rel="import" href="chrome://md-settings/on_startup_page/on_startup_page.ht ml">
6 7
7 <if expr="chromeos"> 8 <if expr="chromeos">
8 <link rel="import" href="chrome://md-settings/internet_page/internet_page.html"> 9 <link rel="import" href="chrome://md-settings/internet_page/internet_page.html">
9 <link rel="import" href="chrome://md-settings/users_page/users_page.html"> 10 <link rel="import" href="chrome://md-settings/users_page/users_page.html">
10 </if> 11 </if>
11 12
12 <if expr="not chromeos"> 13 <if expr="not chromeos">
13 <link rel="import" href="chrome://md-settings/default_browser_page/default_brows er_page.html"> 14 <link rel="import" href="chrome://md-settings/default_browser_page/default_brows er_page.html">
14 <link rel="import" href="chrome://md-settings/signin_page/signin_page.html"> 15 <link rel="import" href="chrome://md-settings/signin_page/signin_page.html">
15 </if> 16 </if>
16 17
17 <dom-module id="settings-basic-page"> 18 <dom-module id="settings-basic-page">
18 <link rel="import" type="css" href="basic_page.css"> 19 <link rel="import" type="css" href="basic_page.css">
19 <template> 20 <template>
20 <if expr="not chromeos"> 21 <if expr="not chromeos">
21 <settings-section i18n-values="page-title:peoplePageTitle" 22 <template is="dom-if" if="[[showPage(pageVisibility.people)]]" restamp>
22 current-route="[[currentRoute]]" section="people"> 23 <settings-section i18n-values="page-title:peoplePageTitle"
23 <settings-signin-page current-route="{{currentRoute}}"> 24 current-route="[[currentRoute]]" section="people">
24 </settings-signin-page> 25 <settings-signin-page current-route="{{currentRoute}}">
25 </settings-section> 26 </settings-signin-page>
27 </settings-section>
28 </template>
26 </if> 29 </if>
27 <if expr="chromeos"> 30 <if expr="chromeos">
28 <settings-section i18n-values="page-title:internetPageTitle" 31 <template is="dom-if" if="[[showPage(pageVisibility.internet)]]" restamp>
29 current-route="[[currentRoute]]" section="internet"> 32 <settings-section i18n-values="page-title:internetPageTitle"
30 <settings-internet-page current-route="{{currentRoute}}"> 33 current-route="[[currentRoute]]" section="internet">
31 </settings-internet-page> 34 <settings-internet-page current-route="{{currentRoute}}">
32 </settings-section> 35 </settings-internet-page>
36 </settings-section>
37 </template>
33 </if> 38 </if>
34 <settings-section i18n-values="page-title:appearancePageTitle" 39 <template is="dom-if" if="[[showPage(pageVisibility.appearance)]]" restamp>
35 current-route="[[currentRoute]]" section="appearance"> 40 <settings-section i18n-values="page-title:appearancePageTitle"
36 <settings-appearance-page prefs="{{prefs}}" 41 current-route="[[currentRoute]]" section="appearance">
37 current-route="[[currentRoute]]"> 42 <settings-appearance-page prefs="{{prefs}}"
38 </settings-appearance-page> 43 current-route="[[currentRoute]]">
39 </settings-section> 44 </settings-appearance-page>
40 45 </settings-section>
41 <settings-section i18n-values="page-title:onStartup" 46 </template>
42 current-route="[[currentRoute]]" section="onStartup"> 47 <template is="dom-if" if="[[showPage(pageVisibility.onStartup)]]" restamp>
43 <settings-on-startup-page prefs="{{prefs}}" 48 <settings-section i18n-values="page-title:onStartup"
44 current-route="{{currentRoute}}"> 49 current-route="[[currentRoute]]" section="onStartup">
45 </settings-on-startup-page> 50 <settings-on-startup-page prefs="{{prefs}}"
46 </settings-section> 51 current-route="{{currentRoute}}">
47 52 </settings-on-startup-page>
48 <settings-section i18n-values="page-title:searchPageTitle" 53 </settings-section>
49 current-route="[[currentRoute]]" section="search"> 54 </template>
50 <settings-search-page current-route="{{currentRoute}}"> 55 <template is="dom-if" if="[[showPage(pageVisibility.search)]]" restamp>
51 </settings-search-page> 56 <settings-section i18n-values="page-title:searchPageTitle"
52 </settings-section> 57 current-route="[[currentRoute]]" section="search">
53 58 <settings-search-page current-route="{{currentRoute}}">
59 </settings-search-page>
60 </settings-section>
61 </template>
54 <if expr="chromeos"> 62 <if expr="chromeos">
55 <settings-section i18n-values="page-title:usersPageTitle" 63 <template is="dom-if" if="[[showPage(pageVisibility.users)]]" restamp>
56 current-route="[[currentRoute]]" section="users"> 64 <settings-section i18n-values="page-title:usersPageTitle"
57 <settings-users-page prefs="{{prefs}}"></settings-users-page> 65 current-route="[[currentRoute]]" section="users">
58 </settings-section> 66 <settings-users-page prefs="{{prefs}}"></settings-users-page>
67 </settings-section>
68 </template>
59 </if> 69 </if>
60 70
61 <if expr="not chromeos"> 71 <if expr="not chromeos">
62 <settings-section i18n-values="page-title:defaultBrowser" 72 <template is="dom-if" if="[[showPage(pageVisibility.defaultBrowser)]]"
63 expand-container="{{expandContainer}}" 73 restamp>
64 current-route="[[currentRoute]]" section="defaultBrowser"> 74 <settings-section i18n-values="page-title:defaultBrowser"
65 <settings-default-browser-page> 75 expand-container="{{expandContainer}}"
66 </settings-default-browser-page> 76 current-route="[[currentRoute]]" section="defaultBrowser">
67 </settings-section> 77 <settings-default-browser-page>
78 </settings-default-browser-page>
79 </settings-section>
80 </template>
68 </if> 81 </if>
69 </template> 82 </template>
70 <script src="basic_page.js"></script> 83 <script src="basic_page.js"></script>
71 </dom-module> 84 </dom-module>
OLDNEW
« no previous file with comments | « chrome/browser/resources/settings/advanced_page/compiled_resources.gyp ('k') | chrome/browser/resources/settings/basic_page/basic_page.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698