chrome/browser/resources/settings/settings_page/compiled_resources.gyp - Issue 1477773003: Use dom-if to hide settings pages and show explicitly.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/settings_page/compiled_resources.gyp

Issue 1477773003: Use dom-if to hide settings pages and show explicitly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/settings/on_startup_page/on_startup_page.html ('K') | « chrome/browser/resources/settings/on_startup_page/on_startup_page.html ('k') | chrome/browser/resources/settings/settings_page/settings_page_visibility.html » ('j') | chrome/browser/resources/settings/settings_page/settings_page_visibility.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright 2015 The Chromium Authors. All rights reserved.	1 # Copyright 2015 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4 {	4 {

5 'targets': [	5 'targets': [

6 {	6 {

7 'target_name': 'cr_search_field',	7 'target_name': 'settings_page_visibility',

8 'dependencies': [	8 'includes': ['../../../../../third_party/closure_compiler/compile_js.gypi' ],

9 '<(DEPTH)/ui/webui/resources/js/compiled_resources2.gyp:assert',

10 ],

11 'includes': ['../../../../../third_party/closure_compiler/compile_js2.gypi '],
Dan Beam 2015/12/08 02:55:27 btw, prefer 2 versions when possible btw, prefer 2 versions when possible stevenjb 2015/12/08 20:07:37 This is new to me, please send out a PSA (or direc Show quoted text On 2015/12/08 02:55:27, Dan Beam wrote: > btw, prefer *2 versions when possible This is new to me, please send out a PSA (or direct me to it if I missed it). I would also rather migrate all of resources/settings if possible. Thanks.
12 },	9 },

13 ],	10 ],

14 }	11 }

OLD	NEW