chrome/browser/resources/settings/settings_page/settings_page_visibility.html - Issue 1477773003: Use dom-if to hide settings pages and show explicitly.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/settings_page/settings_page_visibility.html

Issue 1477773003: Use dom-if to hide settings pages and show explicitly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Feedback Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/settings/compiled_resources.gyp ('K') | « chrome/browser/resources/settings/settings_page/compiled_resources.gyp ('k') | chrome/browser/resources/settings/settings_page/settings_page_visibility.js » ('j') | chrome/browser/resources/settings/settings_page/settings_page_visibility.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1	1 <script src="settings_page_visibility.js"></script>

2 The inner text element of the search input should never be 0-height: PASS

OLD	NEW