Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: chrome/browser/resources/settings/basic_page/basic_page.html

Issue 1477773003: Use dom-if to hide settings pages and show explicitly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Feedback Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« chrome/browser/resources/settings/advanced_page/advanced_page.html ('K') | « chrome/browser/resources/settings/advanced_page/advanced_page.js ('k') | chrome/browser/resources/settings/basic_page/basic_page.js » ('j') | chrome/browser/resources/settings/compiled_resources.gyp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html"> 1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">
2 <link rel="import" href="chrome://md-settings/appearance_page/appearance_page.ht ml"> 2 <link rel="import" href="chrome://md-settings/appearance_page/appearance_page.ht ml">
3 <link rel="import" href="chrome://md-settings/search_page/search_page.html"> 3 <link rel="import" href="chrome://md-settings/search_page/search_page.html">
4 <link rel="import" href="chrome://md-settings/settings_page/settings_page_visibi lity.html">
4 <link rel="import" href="chrome://md-settings/settings_page/settings_section.htm l"> 5 <link rel="import" href="chrome://md-settings/settings_page/settings_section.htm l">
5 <link rel="import" href="chrome://md-settings/on_startup_page/on_startup_page.ht ml"> 6 <link rel="import" href="chrome://md-settings/on_startup_page/on_startup_page.ht ml">
6 7
7 <if expr="chromeos"> 8 <if expr="chromeos">
8 <link rel="import" href="chrome://md-settings/internet_page/internet_page.html"> 9 <link rel="import" href="chrome://md-settings/internet_page/internet_page.html">
9 <link rel="import" href="chrome://md-settings/users_page/users_page.html"> 10 <link rel="import" href="chrome://md-settings/users_page/users_page.html">
10 </if> 11 </if>
11 12
12 <if expr="not chromeos"> 13 <if expr="not chromeos">
13 <link rel="import" href="chrome://md-settings/default_browser_page/default_brows er_page.html"> 14 <link rel="import" href="chrome://md-settings/default_browser_page/default_brows er_page.html">
14 <link rel="import" href="chrome://md-settings/signin_page/signin_page.html"> 15 <link rel="import" href="chrome://md-settings/signin_page/signin_page.html">
15 </if> 16 </if>
16 17
17 <dom-module id="settings-basic-page"> 18 <dom-module id="settings-basic-page">
18 <link rel="import" type="css" href="basic_page.css"> 19 <link rel="import" type="css" href="basic_page.css">
19 <template> 20 <template>
20 <if expr="not chromeos"> 21 <if expr="not chromeos">
21 <settings-section i18n-values="page-title:peoplePageTitle" 22 <settings-section i18n-values="page-title:peoplePageTitle"
22 current-route="[[currentRoute]]" section="people"> 23 current-route="[[currentRoute]]" section="people"
23 <settings-signin-page current-route="{{currentRoute}}"> 24 hidden$="[[!pageVisible.people]]">
24 </settings-signin-page> 25 <template is="dom-if" if="[[pageVisible.people]]">
26 <settings-signin-page current-route="{{currentRoute}}">
27 </settings-signin-page>
28 </template>
25 </settings-section> 29 </settings-section>
26 </if> 30 </if>
27 <if expr="chromeos"> 31 <if expr="chromeos">
28 <settings-section i18n-values="page-title:internetPageTitle" 32 <settings-section i18n-values="page-title:internetPageTitle"
29 current-route="[[currentRoute]]" section="internet"> 33 current-route="[[currentRoute]]" section="internet"
30 <settings-internet-page current-route="{{currentRoute}}"> 34 hidden$="[[!pageVisible.internet]]">
31 </settings-internet-page> 35 <template is="dom-if" if="[[pageVisible.internet]]">
36 <settings-internet-page current-route="{{currentRoute}}">
37 </settings-internet-page>
38 </template>
32 </settings-section> 39 </settings-section>
33 </if> 40 </if>
34 <settings-section i18n-values="page-title:appearancePageTitle" 41 <settings-section i18n-values="page-title:appearancePageTitle"
35 current-route="[[currentRoute]]" section="appearance"> 42 current-route="[[currentRoute]]" section="appearance"
36 <settings-appearance-page prefs="{{prefs}}" 43 hidden$="[[!pageVisible.appearance]]">
37 current-route="[[currentRoute]]"> 44 <template is="dom-if" if="[[pageVisible.appearance]]">
38 </settings-appearance-page> 45 <settings-appearance-page prefs="{{prefs}}"
46 current-route="[[currentRoute]]">
47 </settings-appearance-page>
48 </template>
39 </settings-section> 49 </settings-section>
40
41 <settings-section i18n-values="page-title:onStartup" 50 <settings-section i18n-values="page-title:onStartup"
42 current-route="[[currentRoute]]" section="on-startup"> 51 current-route="[[currentRoute]]" section="onStartup"
43 <settings-on-startup-page prefs="{{prefs}}" 52 hidden$="[[!pageVisible.onStartup]]">
44 current-route="{{currentRoute}}"> 53 <template is="dom-if" if="[[pageVisible.onStartup]]">
45 </settings-on-startup-page> 54 <settings-on-startup-page prefs="{{prefs}}"
55 current-route="{{currentRoute}}">
56 </settings-on-startup-page>
57 </template>
46 </settings-section> 58 </settings-section>
47
48 <settings-section i18n-values="page-title:searchPageTitle" 59 <settings-section i18n-values="page-title:searchPageTitle"
49 current-route="[[currentRoute]]" section="search"> 60 current-route="[[currentRoute]]" section="search"
50 <settings-search-page current-route="{{currentRoute}}"> 61 hidden$="[[!pageVisible.search]]">
51 </settings-search-page> 62 <template is="dom-if" if="[[pageVisible.search]]">
63 <settings-search-page current-route="{{currentRoute}}">
64 </settings-search-page>
65 </template>
52 </settings-section> 66 </settings-section>
53
54 <if expr="chromeos"> 67 <if expr="chromeos">
55 <settings-section i18n-values="page-title:usersPageTitle" 68 <settings-section i18n-values="page-title:usersPageTitle"
56 current-route="[[currentRoute]]" section="users"> 69 current-route="[[currentRoute]]" section="users"
57 <settings-users-page prefs="{{prefs}}"></settings-users-page> 70 hidden$="[[!pageVisible.users]]">
71 <template is="dom-if" if="[[pageVisible.users]]">
72 <settings-users-page prefs="{{prefs}}"></settings-users-page>
73 </template>
58 </settings-section> 74 </settings-section>
59 </if> 75 </if>
60 76
61 <if expr="not chromeos"> 77 <if expr="not chromeos">
62 <settings-section i18n-values="page-title:defaultBrowser" 78 <settings-section i18n-values="page-title:defaultBrowser"
63 expand-container="{{expandContainer}}" 79 expand-container="{{expandContainer}}"
64 current-route="[[currentRoute]]" section="defaultBrowser"> 80 current-route="[[currentRoute]]" section="defaultBrowser"
65 <settings-default-browser-page> 81 hidden$="[[!pageVisible.defaultBrowser]]">
66 </settings-default-browser-page> 82 <template is="dom-if" if="[[pageVisible.defaultBrowser]]">
83 <settings-default-browser-page>
84 </settings-default-browser-page>
85 </template>
67 </settings-section> 86 </settings-section>
68 </if> 87 </if>
69 </template> 88 </template>
70 <script src="basic_page.js"></script> 89 <script src="basic_page.js"></script>
71 </dom-module> 90 </dom-module>
OLDNEW
« chrome/browser/resources/settings/advanced_page/advanced_page.html ('K') | « chrome/browser/resources/settings/advanced_page/advanced_page.js ('k') | chrome/browser/resources/settings/basic_page/basic_page.js » ('j') | chrome/browser/resources/settings/compiled_resources.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698