Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: chrome/browser/resources/settings/advanced_page/advanced_page.html

Issue 1477773003: Use dom-if to hide settings pages and show explicitly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/advanced_page/advanced_page.js » ('j') | chrome/browser/resources/settings/basic_page/basic_page.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html"> 1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">
2 <link rel="import" href="chrome://md-settings/downloads_page/downloads_page.html "> 2 <link rel="import" href="chrome://md-settings/downloads_page/downloads_page.html ">
3 <link rel="import" href="chrome://md-settings/languages_page/languages_page.html "> 3 <link rel="import" href="chrome://md-settings/languages_page/languages_page.html ">
4 <link rel="import" href="chrome://md-settings/passwords_and_forms_page/passwords _and_forms_page.html"> 4 <link rel="import" href="chrome://md-settings/passwords_and_forms_page/passwords _and_forms_page.html">
5 <link rel="import" href="chrome://md-settings/privacy_page/privacy_page.html"> 5 <link rel="import" href="chrome://md-settings/privacy_page/privacy_page.html">
6 <link rel="import" href="chrome://md-settings/reset_page/reset_page.html"> 6 <link rel="import" href="chrome://md-settings/reset_page/reset_page.html">
7 <link rel="import" href="chrome://md-settings/settings_page/settings_page_visibi lity.html">
7 <link rel="import" href="chrome://md-settings/settings_page/settings_section.htm l"> 8 <link rel="import" href="chrome://md-settings/settings_page/settings_section.htm l">
8 <link rel="import" href="chrome://md-settings/site_settings/constants.html"> 9 <link rel="import" href="chrome://md-settings/site_settings/constants.html">
9 <link rel="import" href="chrome://md-settings/site_settings/site_settings_catego ry.html"> 10 <link rel="import" href="chrome://md-settings/site_settings/site_settings_catego ry.html">
10 11
11 <if expr="chromeos"> 12 <if expr="chromeos">
12 <link rel="import" href="chrome://md-settings/a11y_page/a11y_page.html"> 13 <link rel="import" href="chrome://md-settings/a11y_page/a11y_page.html">
13 <link rel="import" href="chrome://md-settings/bluetooth_page/bluetooth_page.html "> 14 <link rel="import" href="chrome://md-settings/bluetooth_page/bluetooth_page.html ">
14 <link rel="import" href="chrome://md-settings/date_time_page/date_time_page.html "> 15 <link rel="import" href="chrome://md-settings/date_time_page/date_time_page.html ">
15 </if> 16 </if>
16 17
17 <dom-module id="settings-advanced-page"> 18 <dom-module id="settings-advanced-page">
18 <link rel="import" type="css" href="advanced_page.css"> 19 <link rel="import" type="css" href="advanced_page.css">
19 <template> 20 <template>
20 <if expr="chromeos"> 21 <if expr="chromeos">
21 <settings-section i18n-values="page-title:dateTimePageTitle" 22 <template is="dom-if" if="[[pageVisible.dateTime]]">
22 current-route="[[currentRoute]]" section="dateTime"> 23 <settings-section i18n-values="page-title:dateTimePageTitle"
23 <settings-date-time-page prefs="{{prefs}}"> 24 current-route="[[currentRoute]]" section="dateTime">
24 </settings-date-time-page> 25 <settings-date-time-page prefs="{{prefs}}">
25 </settings-section> 26 </settings-date-time-page>
27 </settings-section>
28 </template>
26 </if> 29 </if>
27 <settings-section i18n-values="page-title:siteSettingsLocation" 30 <template is="dom-if" if="[[pageVisible.location]]">
28 current-route="[[currentRoute]]" section="location"> 31 <settings-section i18n-values="page-title:siteSettingsLocation"
29 <site-settings-category id="locationCategory" prefs="{{prefs}}" 32 current-route="[[currentRoute]]" section="location">
30 current-route="{{currentRoute}}"> 33 <site-settings-category prefs="{{prefs}}"
31 </site-settings-category> 34 current-route="{{currentRoute}}">
32 </settings-section> 35 </site-settings-category>
33 36 </settings-section>
34 <settings-section i18n-values="page-title:privacyPageTitle" 37 </template>
35 current-route="[[currentRoute]]" section="privacy"> 38 <template is="dom-if" if="[[pageVisible.privacy]]">
36 <settings-privacy-page prefs="{{prefs}}" 39 <settings-section i18n-values="page-title:privacyPageTitle"
37 current-route="{{currentRoute}}"> 40 current-route="[[currentRoute]]" section="privacy">
38 </settings-privacy-page> 41 <settings-privacy-page prefs="{{prefs}}"
39 </settings-section> 42 current-route="{{currentRoute}}">
40 43 </settings-privacy-page>
44 </settings-section>
45 </template>
41 <if expr="chromeos"> 46 <if expr="chromeos">
42 <settings-section i18n-values="page-title:bluetoothPageTitle" 47 <template is="dom-if" if="[[pageVisible.bluetooth]]">
43 current-route="[[currentRoute]]" section="bluetooth"> 48 <settings-section i18n-values="page-title:bluetoothPageTitle"
44 <settings-bluetooth-page current-route="{{currentRoute}}"> 49 current-route="[[currentRoute]]" section="bluetooth">
45 </settings-bluetooth-page> 50 <settings-bluetooth-page current-route="{{currentRoute}}">
46 </settings-section> 51 </settings-bluetooth-page>
52 </settings-section>
53 </template>
47 </if> 54 </if>
48 55
49 <settings-section 56 <template is="dom-if" if="[[pageVisible.passwordsAndForms]]">
50 i18n-values="page-title:passwordsAndAutofillPageTitle" 57 <settings-section
51 current-route="[[currentRoute]]" section="passwordsAndForms"> 58 i18n-values="page-title:passwordsAndAutofillPageTitle"
52 <settings-passwords-and-forms-page prefs="{{prefs}}" 59 current-route="[[currentRoute]]" section="passwordsAndForms">
53 current-route="{{currentRoute}}"> 60 <settings-passwords-and-forms-page prefs="{{prefs}}"
54 </settings-passwords-and-forms-page> 61 current-route="{{currentRoute}}">
55 </settings-section> 62 </settings-passwords-and-forms-page>
56 63 </settings-section>
57 <settings-section i18n-values="page-title:languagesPageTitle" 64 </template>
58 current-route="[[currentRoute]]" section="languages"> 65 <template is="dom-if" if="[[pageVisible.languages]]">
59 <settings-languages-page prefs="{{prefs}}" 66 <settings-section i18n-values="page-title:languagesPageTitle"
60 current-route="{{currentRoute}}"> 67 current-route="[[currentRoute]]" section="languages">
61 </settings-languages-page> 68 <settings-languages-page prefs="{{prefs}}"
62 </settings-section> 69 current-route="{{currentRoute}}">
63 70 </settings-languages-page>
64 <settings-section i18n-values="page-title:downloadsPageTitle" 71 </settings-section>
65 current-route="[[currentRoute]]" section="downloads"> 72 </template>
66 <settings-downloads-page prefs="{{prefs}}"> 73 <template is="dom-if" if="[[pageVisible.downloads]]">
67 </settings-downloads-page> 74 <settings-section i18n-values="page-title:downloadsPageTitle"
68 </settings-section> 75 current-route="[[currentRoute]]" section="downloads">
69 76 <settings-downloads-page prefs="{{prefs}}">
70 <settings-section i18n-values="page-title:resetPageTitle" 77 </settings-downloads-page>
71 current-route="[[currentRoute]]" section="reset"> 78 </settings-section>
72 <settings-reset-page></settings-reset-page> 79 </template>
73 </settings-section> 80 <template is="dom-if" if="[[pageVisible.reset]]">
74 81 <settings-section i18n-values="page-title:resetPageTitle"
82 current-route="[[currentRoute]]" section="reset">
83 <settings-reset-page></settings-reset-page>
84 </settings-section>
85 </template>
75 <if expr="chromeos"> 86 <if expr="chromeos">
76 <!-- TODO(dbeam): find somewhere to stuff "Add more accessibility features" 87 <!-- TODO(dbeam): find somewhere to stuff "Add more accessibility features"
77 on desktop. --> 88 on desktop. -->
78 <settings-section i18n-values="page-title:a11yPageTitle" 89 <template is="dom-if" if="[[pageVisible.a11y]]">
79 current-route="[[currentRoute]]" section="a11y"> 90 <settings-section i18n-values="page-title:a11yPageTitle"
80 <settings-a11y-page prefs="{{prefs}}"></settings-a11y-page> 91 current-route="[[currentRoute]]" section="a11y">
81 </settings-section> 92 <settings-a11y-page prefs="{{prefs}}"></settings-a11y-page>
93 </settings-section>
94 </template>
82 </if> 95 </if>
83 </template> 96 </template>
84 <script src="chrome://md-settings/advanced_page/advanced_page.js"></script> 97 <script src="chrome://md-settings/advanced_page/advanced_page.js"></script>
85 </dom-module> 98 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/settings/advanced_page/advanced_page.js » ('j') | chrome/browser/resources/settings/basic_page/basic_page.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698