Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 1477753002: [turbofan] Implemented the optional Float32RoundTiesEven operator. (Closed)

Created:
5 years ago by ahaas
Modified:
5 years ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@f32trunc
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Implemented the optional Float32RoundTiesEven operator. The Float32RoundTiesEven operator rounds float32 numbers towards the nearest integer. If the distance to two integers is the same, then the result is the even integer. This is the default rounding mode of the ieee 754 floating point standard. I implemented the optional Float32RoundTiesEven operator on x64, ia32, arm, and arm64. R=titzer@chromium.org Committed: https://crrev.com/57117b8339fe990867c4b8cc2c66f029a1a58bc3 Cr-Commit-Position: refs/heads/master@{#32308}

Patch Set 1 #

Patch Set 2 : Merging with the changed codebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -11 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/arm/instruction-codes-arm.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/arm64/instruction-codes-arm64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/machine-operator.h View 2 chunks +13 lines, -11 lines 0 comments Download
M src/compiler/machine-operator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
ahaas
5 years ago (2015-11-25 12:19:47 UTC) #1
titzer
On 2015/11/25 12:19:47, ahaas wrote: lgtm
5 years ago (2015-11-25 12:36:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477753002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477753002/20001
5 years ago (2015-11-25 21:11:06 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-25 21:12:47 UTC) #6
commit-bot: I haz the power
5 years ago (2015-11-25 21:13:28 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/57117b8339fe990867c4b8cc2c66f029a1a58bc3
Cr-Commit-Position: refs/heads/master@{#32308}

Powered by Google App Engine
This is Rietveld 408576698