components/autofill/core/browser/autofill_manager.cc - Issue 1477733003: Replace xmllite with libxml in autofill

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_manager.cc

Issue 1477733003: Replace xmllite with libxml in autofill (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@556433_remove_dead_code

Patch Set: Fix browser tests Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/autofill_manager.h ('k') | components/autofill/core/browser/autofill_xml_parser.h » ('j') | components/autofill/core/browser/autofill_xml_parser.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_manager.cc

diff --git a/components/autofill/core/browser/autofill_manager.cc b/components/autofill/core/browser/autofill_manager.cc

index 0d3c169221bbe20632236c36f96635c88f63c354..e3c5e3c66c9fc84f24197da1106f06db992fd77a 100644

--- a/components/autofill/core/browser/autofill_manager.cc

+++ b/components/autofill/core/browser/autofill_manager.cc

@@ -743,7 +743,7 @@ void AutofillManager::OnSetDataList(const std::vector<base::string16>& values,

}

void AutofillManager::OnLoadedServerPredictions(

- const std::string& response_xml,

+ std::string response_xml,

const std::vector<std::string>& form_signatures) {

// We obtain the current valid FormStructures represented by

// |form_signatures|. We invert both lists because most recent forms are at

@@ -765,7 +765,7 @@ void AutofillManager::OnLoadedServerPredictions(

return;

// Parse and store the server predictions.

- FormStructure::ParseQueryResponse(response_xml, queried_forms,

+ FormStructure::ParseQueryResponse(std::move(response_xml), queried_forms,

client_->GetRapporService());

// Forward form structures to the password generation manager to detect