Replace xmllite with libxml in autofill

components/autofill/core/browser/form_structure.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_FORM_STRUCTURE_H_
 #define COMPONENTS_AUTOFILL_CORE_BROWSER_FORM_STRUCTURE_H_
 
 #include <set>
 #include <string>
 #include <vector>
 
 #include "base/callback.h"
 #include "base/gtest_prod_util.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/scoped_vector.h"
 #include "base/strings/string16.h"
 #include "components/autofill/core/browser/autofill_field.h"
 #include "components/autofill/core/browser/autofill_type.h"
 #include "components/autofill/core/browser/field_types.h"
 #include "url/gurl.h"
 
+class XmlWriter;
+
 enum UploadRequired {
   UPLOAD_NOT_REQUIRED,
   UPLOAD_REQUIRED,
   USE_UPLOAD_RATES
 };
 
 namespace base {
 class TimeTicks;
 }
 
@@ skipping 43 matching lines @@
   // example, there are three valid forms, with 2, 4, and 3 fields. The returned
   // XML would have type info for 9 fields, first two of which would be for the
   // first form, next 4 for the second, and the rest is for the third.
   static bool EncodeQueryRequest(const std::vector<FormStructure*>& forms,
                                  std::vector<std::string>* encoded_signatures,
                                  std::string* encoded_xml);
 
   // Parses the field types from the server query response. |forms| must be the
   // same as the one passed to EncodeQueryRequest when constructing the query.
   // |rappor_service| may be null.
-  static void ParseQueryResponse(const std::string& response_xml,
+  static void ParseQueryResponse(std::string response_xml,
                                  const std::vector<FormStructure*>& forms,
                                  rappor::RapporService* rappor_service);
 
   // Returns predictions using the details from the given |form_structures| and
   // their fields' predicted types.
   static std::vector<FormDataPredictions> GetFieldTypePredictions(
       const std::vector<FormStructure*>& form_structures);
 
   // The unique signature for this form, composed of the target url domain,
   // the form name, and the form field names in a 64-bit hash.
@@ skipping 119 matching lines @@
 
   // 64-bit hash of the string - used in FormSignature and unit-tests.
   static std::string Hash64Bit(const std::string& str);
 
   enum EncodeRequestType {
     QUERY,
     UPLOAD,
     FIELD_ASSIGNMENTS,
   };
 
-  // Adds form info to |encompassing_xml_element|. |request_type| indicates if
-  // it is a query or upload.
+  // Returns true if the form has no fields, or too many.
+  bool IsMalformed() const;
+
+  // Takes |xml_writer| and writes description for |fields_|, according to
+  // |request_type|. Returns false on failure, including when there are no
+  // fields, and true on success.
   bool EncodeFormRequest(EncodeRequestType request_type,
-                         buzz::XmlElement* encompassing_xml_element) const;
+                         XmlWriter* xml_writer) const;
 
   // Classifies each field in |fields_| into a logical section.
   // Sections are identified by the heuristic that a logical section should not
   // include multiple fields of the same autofill type (with some exceptions, as
   // described in the implementation).  Sections are furthermore distinguished
   // as either credit card or non-credit card sections.
   // If |has_author_specified_sections| is true, only the second pass --
   // distinguishing credit card sections from non-credit card ones -- is made.
   void IdentifySections(bool has_author_specified_sections);
 
@@ skipping 46 matching lines @@
 
   // True if the form is a <form>.
   bool is_form_tag_;
 
   DISALLOW_COPY_AND_ASSIGN(FormStructure);
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CORE_BROWSER_FORM_STRUCTURE_H_