Replace xmllite with libxml in autofill

components/autofill/core/browser/autofill_download_manager_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autofill_download_manager.h"
 
 #include <list>
+#include <utility>
 
 #include "base/prefs/pref_service.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/test/histogram_tester.h"
 #include "base/test/test_timeouts.h"
 #include "base/thread_task_runner_handle.h"
 #include "components/autofill/core/browser/autofill_field.h"
 #include "components/autofill/core/browser/autofill_metrics.h"
@@ skipping 56 matching lines @@
         download_manager_(&driver_, prefs_.get(), this) {
     driver_.SetURLRequestContext(request_context_.get());
   }
 
   void LimitCache(size_t cache_size) {
     download_manager_.set_max_form_cache_size(cache_size);
   }
 
   // AutofillDownloadManager::Observer implementation.
   void OnLoadedServerPredictions(
-      const std::string& response_xml,
+      std::string response_xml,
       const std::vector<std::string>& form_signatures) override {
     ResponseData response;
-    response.response = response_xml;
+    response.response = std::move(response_xml);
     response.type_of_response = QUERY_SUCCESSFULL;
     responses_.push_back(response);
   }
 
   void OnUploadedPossibleFieldTypes() override {
     ResponseData response;
     response.type_of_response = UPLOAD_SUCCESSFULL;
     responses_.push_back(response);
   }
 
@@ skipping 68 matching lines @@
   field.label = ASCIIToUTF16("password");
   field.name = ASCIIToUTF16("password");
   field.form_control_type = "password";
   form.fields.push_back(field);
 
   field.label = base::string16();
   field.name = ASCIIToUTF16("Submit");
   field.form_control_type = "submit";
   form.fields.push_back(field);
 
-  FormStructure *form_structure = new FormStructure(form);
+  FormStructure* form_structure = new FormStructure(form);
   ScopedVector<FormStructure> form_structures;
   form_structures.push_back(form_structure);
 
   form.fields.clear();
 
   field.label = ASCIIToUTF16("address");
   field.name = ASCIIToUTF16("address");
   field.form_control_type = "text";
   form.fields.push_back(field);
 
@@ skipping 237 matching lines @@
   form.fields.push_back(field);
 
   field.label = ASCIIToUTF16("First Name");
   field.name = ASCIIToUTF16("firstname");
   form.fields.push_back(field);
 
   field.label = ASCIIToUTF16("Last Name");
   field.name = ASCIIToUTF16("lastname");
   form.fields.push_back(field);
 
-  FormStructure *form_structure = new FormStructure(form);
+  FormStructure* form_structure = new FormStructure(form);
   ScopedVector<FormStructure> form_structures0;
   form_structures0.push_back(form_structure);
 
   // Add a slightly different form, which should result in a different request.
   field.label = ASCIIToUTF16("email");
   field.name = ASCIIToUTF16("email");
   form.fields.push_back(field);
   form_structure = new FormStructure(form);
   ScopedVector<FormStructure> form_structures1;
   form_structures1.push_back(form_structure);
@@ skipping 110 matching lines @@
   fetcher = factory.GetFetcherByID(3);
   ASSERT_TRUE(fetcher);
   FakeOnURLFetchComplete(fetcher, 200, std::string(responses[0]));
   ASSERT_EQ(1U, responses_.size());
   EXPECT_EQ(responses[0], responses_.front().response);
 }
 
 TEST_F(AutofillDownloadTest, QueryRequestIsGzipped) {
   // Expected query (uncompressed for visual verification).
   const char* kExpectedQueryXml =
-      "<?xml version=\"1.0\" encoding=\"UTF-8\"?>"
+      "<?xml version=\"1.0\"?>\n"
       "<autofillquery clientversion=\"6.1.1715.1442/en (GGLL)\">"
       "<form signature=\"14546501144368603154\">"
       "<field signature=\"239111655\"/>"
       "<field signature=\"3763331450\"/>"
       "<field signature=\"3494530716\"/>"
-      "</form></autofillquery>";
+      "</form></autofillquery>\n";
 
   // Create and register factory.
   net::TestURLFetcherFactory factory;
 
   FormData form;
 
   FormFieldData field;
   field.form_control_type = "text";
 
   field.label = ASCIIToUTF16("username");
@@ skipping 24 matching lines @@
   EXPECT_EQ(Compress(kExpectedQueryXml), fetcher->upload_data());
 
   // Proper content-encoding header is defined.
   net::HttpRequestHeaders headers;
   fetcher->GetExtraRequestHeaders(&headers);
   std::string header;
   EXPECT_TRUE(headers.GetHeader("content-encoding", &header));
   EXPECT_EQ("gzip", header);
 
   // Expect that the compression is logged.
-  histogram.ExpectUniqueSample("Autofill.PayloadCompressionRatio.Query", 73, 1);
+  histogram.ExpectUniqueSample("Autofill.PayloadCompressionRatio.Query", 72, 1);
 }
 
 TEST_F(AutofillDownloadTest, UploadRequestIsGzipped) {
   // Expected upload (uncompressed for visual verification).
   const char* kExpectedUploadXml =
-      "<?xml version=\"1.0\" encoding=\"UTF-8\"?>"
+      "<?xml version=\"1.0\"?>\n"
       "<autofillupload clientversion=\"6.1.1715.1442/en (GGLL)\""
       " formsignature=\"14546501144368603154\" autofillused=\"true\""
-      " datapresent=\"\"/>";
+      " datapresent=\"\"/>\n";
 
   // Create and register factory.
   net::TestURLFetcherFactory factory;
 
   FormData form;
 
   FormFieldData field;
   field.form_control_type = "text";
 
   field.label = ASCIIToUTF16("username");
@@ skipping 27 matching lines @@
   EXPECT_EQ(Compress(kExpectedUploadXml), fetcher->upload_data());
 
   // Proper content-encoding header is defined.
   net::HttpRequestHeaders headers;
   fetcher->GetExtraRequestHeaders(&headers);
   std::string header;
   EXPECT_TRUE(headers.GetHeader("content-encoding", &header));
   EXPECT_EQ("gzip", header);
 
   // Expect that the compression is logged.
-  histogram.ExpectUniqueSample("Autofill.PayloadCompressionRatio.Upload", 92,
+  histogram.ExpectUniqueSample("Autofill.PayloadCompressionRatio.Upload", 95,
                                1);
 }
 
 }  // namespace autofill