ui/arc/BUILD.gn - Issue 1477733002: Add ArcNotificationManager for new ARC notification

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/arc/BUILD.gn

Issue 1477733002: Add ArcNotificationManager for new ARC notification (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright 2016 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 import("//build/config/ui.gni")

	6

	7 static_library("arc") {

	8 sources = [

	9 "notification/arc_notification_item.cc",

	10 "notification/arc_notification_item.h",

	11 "notification/arc_notification_manager.cc",

	12 "notification/arc_notification_manager.h",

	13 ]

	14

	15 deps = [

	16 "//base",

	17 "//components/arc:arc_bindings",

	18 "//components/signin/core/account_id",

	19 "//third_party/WebKit/public:blink_headers",
	sky 2016/01/06 22:02:36 Having this code depend upon webkit is unfortunate Having this code depend upon webkit is unfortunate. Is there a way to structure it so that you don't depend upon webkit? yoshiki 2016/01/08 10:32:58 I removed the dependency on webkit. Show quoted text On 2016/01/06 22:02:36, sky wrote: > Having this code depend upon webkit is unfortunate. Is there a way to structure > it so that you don't depend upon webkit? I removed the dependency on webkit.
	20 "//ui/gfx",

	21 "//ui/message_center",

	22 ]

	23 }

OLD	NEW

« components/arc/arc_service_manager.h ('K') | « components/arc/arc_service_manager.cc ('k') | ui/arc/DEPS » ('j') | ui/arc/notification/arc_notification_item.cc » ('J')