Add ArcNotificationManager for new ARC notification

chrome/browser/chromeos/chrome_browser_main_chromeos.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/chrome_browser_main_chromeos.h"
 
 #include <string>
 #include <vector>
 
 #include "ash/ash_switches.h"
@@ skipping 59 matching lines @@
 #include "chrome/browser/chromeos/settings/device_oauth2_token_service_factory.h"
 #include "chrome/browser/chromeos/settings/device_settings_service.h"
 #include "chrome/browser/chromeos/status/data_promo_notification.h"
 #include "chrome/browser/chromeos/system/input_device_settings.h"
 #include "chrome/browser/chromeos/upgrade_detector_chromeos.h"
 #include "chrome/browser/defaults.h"
 #include "chrome/browser/lifetime/application_lifetime.h"
 #include "chrome/browser/net/chrome_network_delegate.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_manager.h"
+#include "chrome/browser/ui/ash/multi_user/multi_user_util.h"
 #include "chrome/browser/ui/ash/network_connect_delegate_chromeos.h"
 #include "chrome/common/channel_info.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/logging_chrome.h"
 #include "chrome/common/pref_names.h"
 #include "chromeos/audio/audio_devices_pref_handler_impl.h"
 #include "chromeos/audio/cras_audio_handler.h"
 #include "chromeos/cert_loader.h"
@@ skipping 544 matching lines @@
       new RendererFreezer(scoped_ptr<RendererFreezer::Delegate>(
           new FreezerCgroupProcessManager())));
 
   g_browser_process->platform_part()->InitializeAutomaticRebootManager();
   g_browser_process->platform_part()->InitializeDeviceDisablingManager();
 
   // This observer cannot be created earlier because it requires the shell to be
   // available.
   idle_action_warning_observer_.reset(new IdleActionWarningObserver());
 
+  if (arc::ArcBridgeService::GetEnabled(
+          base::CommandLine::ForCurrentProcess())) {
+    DCHECK(arc_service_manager_);
+    arc_service_manager_->PostProfileInit(
+        multi_user_util::GetAccountIdFromProfile(profile()));

[xiyuan, 2015/12/21 22:56:36]

IIRC, this code path is usually executed on the login screen (except for the
browser restart case). The profile() is most likely to be the signin profile
thus would not give your the correct AccountId for user.

Have you tried with "--login-manager" or on a real device? On dev box, the
default is to run with a stub user so the code here may look like giving you a
user profile but that is not the case on real devices.

If you need user profile, maybe we can add the code to
UserSessionManager::FinalizePrepareProfile [1].

[1]
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/chr...

[yoshiki, 2015/12/22 10:13:53]

I checked that the previous code (hooking is in PostProfileInit) worked well in
the real device. But what I want is the primary user profile, so I move the code
to the login manager. Thanks.

[xiyuan, 2015/12/22 16:10:17]

Interesting. That means the AccountId of profile is probably not really used
since it would be always empty for signin profile. 

+  }
+
   ChromeBrowserMainPartsLinux::PostProfileInit();
 }
 
 void ChromeBrowserMainPartsChromeos::PreBrowserStart() {
   // -- This used to be in ChromeBrowserMainParts::PreMainMessageLoopRun()
   // -- just before MetricsService::LogNeedForCleanShutdown().
 
   // Start the external metrics service, which collects metrics from Chrome OS
   // and passes them to the browser process.
   external_metrics_ = new chromeos::ExternalMetrics;
@@ skipping 169 matching lines @@
   // Destroy DBus services immediately after threads are stopped.
   dbus_services_.reset();
 
   ChromeBrowserMainPartsLinux::PostDestroyThreads();
 
   // Destroy DeviceSettingsService after g_browser_process.
   DeviceSettingsService::Shutdown();
 }
 
 }  //  namespace chromeos