Add ArcNotificationManager for new ARC notification

chrome/browser/chromeos/arc/notification/arc_notification_manager.cc

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/chromeos/arc/notification/arc_notification_manager.h"
+
+#include "base/stl_util.h"
+#include "chrome/browser/browser_process.h"
+#include "chrome/browser/chromeos/arc/notification/arc_notification_item.h"
+
+namespace chromeos {
+
+ArcNotificationManager::ArcNotificationManager(
+    arc::ArcBridgeService* arc_bridge,
+    Profile* main_profile)
+    : arc_bridge_(arc_bridge), main_profile_(main_profile) {
+  // This must be initialized after ArcBridgeService.
+  DCHECK(arc::ArcBridgeService::Get());

[elijahtaylor1, 2015/12/09 06:41:25]

comments on https://codereview.chromium.org/1495723004/ suggest avoiding getters
like this, instead preferring to maintain proper relationships and lifetimes
between objects.

What are you testing anyway with this, do we expect the bridge service to
change?  It's also weird because you do have an arc_bridge_ member but below use
the global getter instead

[yoshiki, 2015/12/09 17:11:09]

I want to ensure that this is initialized after the bridge service. So I changed
this to check the given instance.

+  DCHECK_EQ(arc_bridge_, arc::ArcBridgeService::Get());
+  arc_bridge_->AddNotificationObserver(this);
+}
+
+ArcNotificationManager::~ArcNotificationManager() {
+  STLDeleteValues(&items_);
+  // This should be free'd before ArcBridgeService.

[elijahtaylor1, 2015/12/09 06:41:26]

is this actually guaranteed?

[yoshiki, 2015/12/09 17:11:09]

It's guaranteed in the definition order in chrome_browser_main_chromeos.cc. The
below DCHECK checks that.

+  DCHECK(arc::ArcBridgeService::Get());
+  DCHECK_EQ(arc_bridge_, arc::ArcBridgeService::Get());
+  arc_bridge_->RemoveNotificationObserver(this);
+}
+
+void ArcNotificationManager::OnNotificationPostedFromAndroid(
+    const arc::ArcNotificationData& data) {
+  // Show a notification on the main user's desktop as for now.
+  // TODO(yoshiki): Consider multi-user.

[elijahtaylor1, 2015/12/09 06:41:26]

I don't know how multi-user works but I would assume a different profile (and
maybe browser process) so maybe nothing needs to be done?  Please talk to
someone before putting these comments in

[yoshiki, 2015/12/09 17:11:09]

I meant that "multi-user" is simultaneous multi-user login feature on Chrome OS.
 
We must pass a profile ID, which is generated from profile, to a notification
instance, to specify the target desktop.

I'm not sure if ARC++ supports multi-user, but as for now, a notification should
be shown only on the primary user's desktop.

+  ArcNotificationItem* item = new ArcNotificationItem(
+      this, g_browser_process->message_center(), data, main_profile_);
+  items_.insert(make_pair(data.key, item));
+}
+
+void ArcNotificationManager::OnNotificationRemovedFromAndroid(
+    const std::string& key) {
+  Items::iterator it = items_.find(key);
+  if (it != items_.end()) {
+    ArcNotificationItem* item = it->second;
+    items_.erase(it);
+
+    item->OnClosedFromAndroid();
+    delete item;
+  } else {
+    VLOG(3) << "Android requested to remove the notification (key: " << key

[elijahtaylor1, 2015/12/09 06:41:25]

s/the/a/

[yoshiki, 2015/12/09 17:11:09]

Done.

+            << "), but it has already gone.";

[elijahtaylor1, 2015/12/09 06:41:26]

s/has/is/

[yoshiki, 2015/12/09 17:11:09]

Done.

+  }
+}
+
+void ArcNotificationManager::NotifyNotificationRemovedFromChrome(
+    const std::string& key) {
+  // Note: This method may be also called by ArcNotificationItem during
+  // OnNotificationRemovedFromAndroid(), since that method should removes
+  // the notification on Chrome UI.
+
+  Items::iterator it = items_.find(key);
+  if (it != items_.end()) {
+    ArcNotificationItem* item = it->second;
+    items_.erase(it);
+
+    arc::ArcBridgeService::Get()->SendNotificationEventToAndroid(
+        key, arc::ArcNotificationEvent::CLOSED);
+    delete item;
+  }
+}
+
+void ArcNotificationManager::NotifyNotificationClickedFromChrome(
+    const std::string& key) {
+  Items::iterator it = items_.find(key);
+  if (it != items_.end()) {
+    arc::ArcBridgeService::Get()->SendNotificationEventToAndroid(
+        key, arc::ArcNotificationEvent::BODY_CLICKED);
+  }
+}
+
+}  // namespace chromeos