Paint tab-loading throbbers into a ui::Layer (reland).

Paint tab-loading throbbers into a ui::Layer (reland).

In views browsers, updating the tab loading throbber currently requires
a repaint that starts at the BrowserView and trickles the damage
rectangle down until it reaches the favicon area. This uses a lot of CPU
and energy: about 11 watts above idle on a MacBook Pro (and significant
CPU on Linux) for a single "waiting" spinner.

Giving the throbber a layer allows the repaint to be isolated, with
compositing done on the GPU. This brings total energy usage down to
about 2.5 watts above idle.

Plots at http://crbug.com/391646#c44

Previously reviewed in https://codereview.chromium.org/1393193002/.
Landed but reverted since it tickled a pre-existing lifetime issue,
now fixed.

BUG=391646
TEST=Spinners should look and behave the same, but use less energy/CPU.

Committed: https://crrev.com/859410a5e85488c0b79de51814351f30cf2814a5
Cr-Commit-Position: refs/heads/master@{#362878}

[tapted, 2015-11-25 06:19:33]

Description was changed from

==========
Paint tab-loading throbbers into a ui::Layer (attempt #2).

In views browsers, updating the tab loading throbber currently requires
a repaint that starts at the BrowserView and trickles the damage
rectangle down until it reaches the favicon area. This uses a lot of CPU
and energy: about 11 watts above idle on a MacBook Pro (and significant
CPU on Linux) for a single "waiting" spinner.

Giving the throbber a layer allows the repaint to be isolated, with
compositing done on the GPU. This brings total energy usage down to
about 2.5 watts above idle.

Plots at http://crbug.com/391646#c44

Previously landed in r355514, reverted since it tickled a (pre-existing?)
lifetime issue

BUG=391646
TEST=Spinners should look and behave the same, but use less energy/CPU.
==========

to

==========
Paint tab-loading throbbers into a ui::Layer (attempt #2).

In views browsers, updating the tab loading throbber currently requires
a repaint that starts at the BrowserView and trickles the damage
rectangle down until it reaches the favicon area. This uses a lot of CPU
and energy: about 11 watts above idle on a MacBook Pro (and significant
CPU on Linux) for a single "waiting" spinner.

Giving the throbber a layer allows the repaint to be isolated, with
compositing done on the GPU. This brings total energy usage down to
about 2.5 watts above idle.

Plots at http://crbug.com/391646#c44

Previously reviewed in https://codereview.chromium.org/1393193002/.
Landed but reverted since it tickled a (pre-existing?) lifetime issue.

BUG=391646
TEST=Spinners should look and behave the same, but use less energy/CPU.
==========

[tapted, 2015-11-27 01:59:01]

Patchset #2 (id:20001) has been deleted

[tapted, 2015-11-27 01:59:36]

Description was changed from

==========
Paint tab-loading throbbers into a ui::Layer (attempt #2).

In views browsers, updating the tab loading throbber currently requires
a repaint that starts at the BrowserView and trickles the damage
rectangle down until it reaches the favicon area. This uses a lot of CPU
and energy: about 11 watts above idle on a MacBook Pro (and significant
CPU on Linux) for a single "waiting" spinner.

Giving the throbber a layer allows the repaint to be isolated, with
compositing done on the GPU. This brings total energy usage down to
about 2.5 watts above idle.

Plots at http://crbug.com/391646#c44

Previously reviewed in https://codereview.chromium.org/1393193002/.
Landed but reverted since it tickled a (pre-existing?) lifetime issue.

BUG=391646
TEST=Spinners should look and behave the same, but use less energy/CPU.
==========

to

==========
Paint tab-loading throbbers into a ui::Layer (attempt #2).

In views browsers, updating the tab loading throbber currently requires
a repaint that starts at the BrowserView and trickles the damage
rectangle down until it reaches the favicon area. This uses a lot of CPU
and energy: about 11 watts above idle on a MacBook Pro (and significant
CPU on Linux) for a single "waiting" spinner.

Giving the throbber a layer allows the repaint to be isolated, with
compositing done on the GPU. This brings total energy usage down to
about 2.5 watts above idle.

Plots at http://crbug.com/391646#c44

Previously reviewed in https://codereview.chromium.org/1393193002/.
Landed but reverted since it tickled a pre-existing lifetime issue.

BUG=391646
TEST=Spinners should look and behave the same, but use less energy/CPU.
==========

[tapted, 2015-11-27 01:59:53]

Description was changed from

==========
Paint tab-loading throbbers into a ui::Layer (attempt #2).

In views browsers, updating the tab loading throbber currently requires
a repaint that starts at the BrowserView and trickles the damage
rectangle down until it reaches the favicon area. This uses a lot of CPU
and energy: about 11 watts above idle on a MacBook Pro (and significant
CPU on Linux) for a single "waiting" spinner.

Giving the throbber a layer allows the repaint to be isolated, with
compositing done on the GPU. This brings total energy usage down to
about 2.5 watts above idle.

Plots at http://crbug.com/391646#c44

Previously reviewed in https://codereview.chromium.org/1393193002/.
Landed but reverted since it tickled a pre-existing lifetime issue.

BUG=391646
TEST=Spinners should look and behave the same, but use less energy/CPU.
==========

to

==========
Paint tab-loading throbbers into a ui::Layer (reland).

In views browsers, updating the tab loading throbber currently requires
a repaint that starts at the BrowserView and trickles the damage
rectangle down until it reaches the favicon area. This uses a lot of CPU
and energy: about 11 watts above idle on a MacBook Pro (and significant
CPU on Linux) for a single "waiting" spinner.

Giving the throbber a layer allows the repaint to be isolated, with
compositing done on the GPU. This brings total energy usage down to
about 2.5 watts above idle.

Plots at http://crbug.com/391646#c44

Previously reviewed in https://codereview.chromium.org/1393193002/.
Landed but reverted since it tickled a pre-existing lifetime issue.

BUG=391646
TEST=Spinners should look and behave the same, but use less energy/CPU.
==========

[tapted, 2015-11-27 02:05:58]

Description was changed from

==========
Paint tab-loading throbbers into a ui::Layer (reland).

In views browsers, updating the tab loading throbber currently requires
a repaint that starts at the BrowserView and trickles the damage
rectangle down until it reaches the favicon area. This uses a lot of CPU
and energy: about 11 watts above idle on a MacBook Pro (and significant
CPU on Linux) for a single "waiting" spinner.

Giving the throbber a layer allows the repaint to be isolated, with
compositing done on the GPU. This brings total energy usage down to
about 2.5 watts above idle.

Plots at http://crbug.com/391646#c44

Previously reviewed in https://codereview.chromium.org/1393193002/.
Landed but reverted since it tickled a pre-existing lifetime issue.

BUG=391646
TEST=Spinners should look and behave the same, but use less energy/CPU.
==========

to

==========
Paint tab-loading throbbers into a ui::Layer (reland).

In views browsers, updating the tab loading throbber currently requires
a repaint that starts at the BrowserView and trickles the damage
rectangle down until it reaches the favicon area. This uses a lot of CPU
and energy: about 11 watts above idle on a MacBook Pro (and significant
CPU on Linux) for a single "waiting" spinner.

Giving the throbber a layer allows the repaint to be isolated, with
compositing done on the GPU. This brings total energy usage down to
about 2.5 watts above idle.

Plots at http://crbug.com/391646#c44

Previously reviewed in https://codereview.chromium.org/1393193002/.
Landed but reverted since it tickled a pre-existing lifetime issue,
now fixed.

BUG=391646
TEST=Spinners should look and behave the same, but use less energy/CPU.
==========

[sky, 2015-11-30 16:55:08]

sky@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2015-11-30 16:55:08]

Rubber stamp LGTM

[tapted, 2015-12-03 00:22:16]

Thanks sky!

The fix stuck it's landing, and I'm entering a build sheriff shift, so now's
probably a good time to land this. -> CQ time \o/

[tapted, 2015-12-03 00:23:47]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2015-12-03 00:24:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1477713002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1477713002/40001

[commit-bot: I haz the power, 2015-12-03 00:31:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-03 00:31:18]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[tapted, 2015-12-03 02:33:44]

The CQ bit was checked by tapted@chromium.org

[tapted, 2015-12-03 02:33:44]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1477713002/#ps60001
(title: "Rebase for r362326 and r362195 conflicts")

[commit-bot: I haz the power, 2015-12-03 02:34:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1477713002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1477713002/60001

[commit-bot: I haz the power, 2015-12-03 03:00:47]

Description was changed from

==========
Paint tab-loading throbbers into a ui::Layer (reland).

In views browsers, updating the tab loading throbber currently requires
a repaint that starts at the BrowserView and trickles the damage
rectangle down until it reaches the favicon area. This uses a lot of CPU
and energy: about 11 watts above idle on a MacBook Pro (and significant
CPU on Linux) for a single "waiting" spinner.

Giving the throbber a layer allows the repaint to be isolated, with
compositing done on the GPU. This brings total energy usage down to
about 2.5 watts above idle.

Plots at http://crbug.com/391646#c44

Previously reviewed in https://codereview.chromium.org/1393193002/.
Landed but reverted since it tickled a pre-existing lifetime issue,
now fixed.

BUG=391646
TEST=Spinners should look and behave the same, but use less energy/CPU.
==========

to

==========
Paint tab-loading throbbers into a ui::Layer (reland).

In views browsers, updating the tab loading throbber currently requires
a repaint that starts at the BrowserView and trickles the damage
rectangle down until it reaches the favicon area. This uses a lot of CPU
and energy: about 11 watts above idle on a MacBook Pro (and significant
CPU on Linux) for a single "waiting" spinner.

Giving the throbber a layer allows the repaint to be isolated, with
compositing done on the GPU. This brings total energy usage down to
about 2.5 watts above idle.

Plots at http://crbug.com/391646#c44

Previously reviewed in https://codereview.chromium.org/1393193002/.
Landed but reverted since it tickled a pre-existing lifetime issue,
now fixed.

BUG=391646
TEST=Spinners should look and behave the same, but use less energy/CPU.
==========

[commit-bot: I haz the power, 2015-12-03 03:00:48]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-12-03 03:01:36]

Description was changed from

==========
Paint tab-loading throbbers into a ui::Layer (reland).

In views browsers, updating the tab loading throbber currently requires
a repaint that starts at the BrowserView and trickles the damage
rectangle down until it reaches the favicon area. This uses a lot of CPU
and energy: about 11 watts above idle on a MacBook Pro (and significant
CPU on Linux) for a single "waiting" spinner.

Giving the throbber a layer allows the repaint to be isolated, with
compositing done on the GPU. This brings total energy usage down to
about 2.5 watts above idle.

Plots at http://crbug.com/391646#c44

Previously reviewed in https://codereview.chromium.org/1393193002/.
Landed but reverted since it tickled a pre-existing lifetime issue,
now fixed.

BUG=391646
TEST=Spinners should look and behave the same, but use less energy/CPU.
==========

to

==========
Paint tab-loading throbbers into a ui::Layer (reland).

In views browsers, updating the tab loading throbber currently requires
a repaint that starts at the BrowserView and trickles the damage
rectangle down until it reaches the favicon area. This uses a lot of CPU
and energy: about 11 watts above idle on a MacBook Pro (and significant
CPU on Linux) for a single "waiting" spinner.

Giving the throbber a layer allows the repaint to be isolated, with
compositing done on the GPU. This brings total energy usage down to
about 2.5 watts above idle.

Plots at http://crbug.com/391646#c44

Previously reviewed in https://codereview.chromium.org/1393193002/.
Landed but reverted since it tickled a pre-existing lifetime issue,
now fixed.

BUG=391646
TEST=Spinners should look and behave the same, but use less energy/CPU.

Committed: https://crrev.com/859410a5e85488c0b79de51814351f30cf2814a5
Cr-Commit-Position: refs/heads/master@{#362878}
==========

[commit-bot: I haz the power, 2015-12-03 03:01:37]

Patchset 3 (id:??) landed as
https://crrev.com/859410a5e85488c0b79de51814351f30cf2814a5
Cr-Commit-Position: refs/heads/master@{#362878}