Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1477683003: cps_ir: Constant fold lengths of constants (Closed)

Created:
5 years ago by sra1
Modified:
5 years ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

cps_ir: Constant fold lengths of constants Replace GetLength of constant String and List values with the length. This treats constants in line with known length container masks. R=asgerf@google.com Committed: https://github.com/dart-lang/sdk/commit/43c886d7522dffb4ddc606619c556f4f33c072ec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -6 lines) Patch
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 3 chunks +24 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
sra1
5 years ago (2015-11-25 04:38:48 UTC) #3
asgerf
lgtm
5 years ago (2015-11-25 09:58:35 UTC) #4
sra1
5 years ago (2015-11-25 18:15:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
43c886d7522dffb4ddc606619c556f4f33c072ec (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698