Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1477683002: X87: Make fast_exp take an Isolate* paramter. (Closed)

Created:
5 years ago by zhengxing.li
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Make fast_exp take an Isolate* paramter. port 0fb2edd15dd108e54c73dd413dff6e192fb7ec0c (r32217) original commit message: We still share the code globally, but if we wanted, it would be easy to make it per isolate now BUG= Committed: https://crrev.com/116a248dba55ab1e35e8160ad0cef8729a50f776 Cr-Commit-Position: refs/heads/master@{#32242}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M src/x87/codegen-x87.cc View 1 chunk +3 lines, -4 lines 1 comment Download

Messages

Total messages: 9 (2 generated)
zhengxing.li
5 years ago (2015-11-25 04:02:56 UTC) #2
Weiliang
lgtm
5 years ago (2015-11-25 04:06:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477683002/1
5 years ago (2015-11-25 04:06:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 04:51:29 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/116a248dba55ab1e35e8160ad0cef8729a50f776 Cr-Commit-Position: refs/heads/master@{#32242}
5 years ago (2015-11-25 04:51:57 UTC) #7
jochen (gone - plz use gerrit)
https://codereview.chromium.org/1477683002/diff/1/src/x87/codegen-x87.cc File src/x87/codegen-x87.cc (right): https://codereview.chromium.org/1477683002/diff/1/src/x87/codegen-x87.cc#newcode38 src/x87/codegen-x87.cc:38: return x87_std_exp; the init_fast_exp_function() in codegen.cc already uses std::exp ...
5 years ago (2015-11-25 09:01:37 UTC) #8
zhengxing.li
5 years ago (2015-11-25 09:14:25 UTC) #9
Message was sent while issue was closed.
On 2015/11/25 09:01:37, jochen wrote:
> https://codereview.chromium.org/1477683002/diff/1/src/x87/codegen-x87.cc
> File src/x87/codegen-x87.cc (right):
> 
>
https://codereview.chromium.org/1477683002/diff/1/src/x87/codegen-x87.cc#newc...
> src/x87/codegen-x87.cc:38: return x87_std_exp;
> the init_fast_exp_function() in codegen.cc already uses std::exp with
> CreateExpFunction returns a nullptr

Thanks! jochen.

This port intend to make the x87 port of V8 master health ASAP. I will work on
the optimized CreateExpFunction once I finished all pending patches that need to
be ported.

Powered by Google App Engine
This is Rietveld 408576698