Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 1477673002: X87: [compiler] No need to push literal index in VisitArrayLiteral. (Closed)

Created:
5 years ago by zhengxing.li
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [compiler] No need to push literal index in VisitArrayLiteral. port 9846f386f08e2aaf897851f0f54c0967c51484fb (r32205) original commit message: The literal index is being pushed onto the stack while evaluating the non-constant subexpressions, but never used in fullcodegen (and hence not used in the optimizing compilers). BUG= Committed: https://crrev.com/5250825fb09a3d4b4755bac2f66720720c27039c Cr-Commit-Position: refs/heads/master@{#32241}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 3 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
zhengxing.li
5 years ago (2015-11-25 03:59:13 UTC) #2
Weiliang
lgtm
5 years ago (2015-11-25 04:05:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477673002/1
5 years ago (2015-11-25 04:05:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 04:40:42 UTC) #6
commit-bot: I haz the power
5 years ago (2015-11-25 04:41:26 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5250825fb09a3d4b4755bac2f66720720c27039c
Cr-Commit-Position: refs/heads/master@{#32241}

Powered by Google App Engine
This is Rietveld 408576698