Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 1477663002: X87: [turbofan] Switch passing of new.target to register. (Closed)

Created:
5 years ago by zhengxing.li
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] Switch passing of new.target to register. port 7c45b005296fc326490a0703add50505518aaa51 (r32203) original commit message: This passes the new.target value in a register instead of through a side-channel via the construct stub. Note that only TurboFan code uses the register value so far, but unoptimized code will be switched soon. BUG= Committed: https://crrev.com/1266842b3b1e091d2e04c9769c29fd8c5849e260 Cr-Commit-Position: refs/heads/master@{#32240}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -33 lines) Patch
M src/crankshaft/x87/lithium-codegen-x87.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/x87/builtins-x87.cc View 3 chunks +12 lines, -6 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 2 chunks +9 lines, -14 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 5 chunks +17 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
zhengxing.li
5 years ago (2015-11-25 03:53:58 UTC) #2
Weiliang
lgtm
5 years ago (2015-11-25 04:05:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477663002/1
5 years ago (2015-11-25 04:05:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 04:31:28 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1266842b3b1e091d2e04c9769c29fd8c5849e260 Cr-Commit-Position: refs/heads/master@{#32240}
5 years ago (2015-11-25 04:31:50 UTC) #7
Michael Starzinger
5 years ago (2015-11-25 09:04:44 UTC) #8
Message was sent while issue was closed.
LGTM. Thanks!

Powered by Google App Engine
This is Rietveld 408576698