Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Unified Diff: skia/ext/refptr.h

Issue 1477643002: Remove the TYPE_WITH_MOVE_CONSTRUCTOR_FOR_CPP_03 macro. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@basepass
Patch Set: type-with-move: . Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: skia/ext/refptr.h
diff --git a/skia/ext/refptr.h b/skia/ext/refptr.h
index a7ba7ffb78542a7ec64e90dae696d0dfcd2e08fc..c2adac82bfbf57e3b06ba21e5af717307eb71fbd 100644
--- a/skia/ext/refptr.h
+++ b/skia/ext/refptr.h
@@ -7,7 +7,6 @@
#include <algorithm>
-#include "base/move.h"
#include "third_party/skia/include/core/SkRefCnt.h"
namespace skia {
@@ -52,7 +51,6 @@ namespace skia {
// for you.
template<typename T>
class RefPtr {
- TYPE_WITH_MOVE_CONSTRUCTOR_FOR_CPP_03(RefPtr)
public:
RefPtr() : ptr_(nullptr) {}
@@ -97,7 +95,7 @@ class RefPtr {
template <typename U>
RefPtr& operator=(RefPtr<U>&& other) {
- RefPtr<T> temp(other.Pass());
+ RefPtr<T> temp(std::move(other));
std::swap(ptr_, temp.ptr_);
return *this;
}

Powered by Google App Engine
This is Rietveld 408576698