Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1029)

Issue 147763009: Add the client address to the Public Reset packet. (Closed)

Created:
6 years, 10 months ago by wtc
Modified:
6 years, 10 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Add the client address to the Public Reset packet. For future extensibility, encode the fields of QuicPublicResetPacket as a CryptoHandshakeMessage, which is essentially a QuicTagValueMap. Move the CryptoHandshakeMessage class to its own files. Move the QuicTagValueMap type from crypto_protocol.h to quic_protocol.h. Merge internal CL: 60963943 Note: net/quic/crypto/crypto_handshake_message.{cc,h} were added separately in https://codereview.chromium.org/154643006. R=rch@chromium.org,rtenneti@chromium.org BUG=none TEST=net_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248898

Patch Set 1 #

Patch Set 2 : Add quic_sent_packet_manager.h back #

Patch Set 3 : Remove crypto_handshake_message.* from the CL; they were committed separately #

Unified diffs Side-by-side diffs Delta from patch set Stats (+353 lines, -477 lines) Patch
M net/net.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/crypto/crypto_framer.h View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/crypto/crypto_framer.cc View 4 chunks +8 lines, -3 lines 0 comments Download
M net/quic/crypto/crypto_handshake.h View 1 chunk +0 lines, -124 lines 0 comments Download
M net/quic/crypto/crypto_handshake.cc View 1 chunk +0 lines, -310 lines 0 comments Download
M net/quic/crypto/crypto_protocol.h View 4 chunks +7 lines, -5 lines 0 comments Download
M net/quic/crypto/quic_crypto_client_config.h View 1 chunk +5 lines, -0 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_config.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/quic_config.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/quic_config_test.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/quic_connection_logger.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_crypto_stream.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_data_stream.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_framer.cc View 5 chunks +66 lines, -14 lines 0 comments Download
M net/quic/quic_framer_test.cc View 5 chunks +232 lines, -3 lines 0 comments Download
M net/quic/quic_protocol.h View 6 chunks +5 lines, -4 lines 0 comments Download
M net/quic/quic_protocol.cc View 2 chunks +1 line, -6 lines 0 comments Download
M net/quic/quic_sent_packet_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_session_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_stream_sequencer_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_packet_maker.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/quic_server_session_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/quic_time_wait_list_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/quic_time_wait_list_manager_test.cc View 3 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
wtc
6 years, 10 months ago (2014-02-04 20:59:27 UTC) #1
Ryan Hamilton
lgtm
6 years, 10 months ago (2014-02-05 01:14:25 UTC) #2
wtc
The CQ bit was checked by wtc@chromium.org
6 years, 10 months ago (2014-02-05 01:57:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/147763009/90001
6 years, 10 months ago (2014-02-05 03:51:24 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 07:23:27 UTC) #5
Message was sent while issue was closed.
Change committed as 248898

Powered by Google App Engine
This is Rietveld 408576698