Issue 147763006: Support loads from primitive values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 147763006: Support loads from primitive values. (Closed)

Created:
6 years, 10 months ago by Toon Verwaest

Modified:
6 years, 10 months ago

Reviewers:
dcarney, Jarin

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Support loads from primitive values. This also changes load computation to use HeapTypes rather than Maps. TODO: move conversion between maps and heaptypes earlier in the process, already in the oracle. BUG= R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18938

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+319 lines, -104 lines)			Patch
M	src/accessors.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/accessors.cc	View	2 chunks	+14 lines, -11 lines	0 comments	Download
M	src/hydrogen.h	View	5 chunks	+39 lines, -23 lines	0 comments	Download
M	src/hydrogen.cc	View	16 chunks	+160 lines, -66 lines	0 comments	Download
M	src/hydrogen-instructions.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	src/ic.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
A	test/mjsunit/value-wrapper-accessor.js	View	1 chunk	+99 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

PTAL. This splits off a large chunk of the Call IC removal CL.

6 years, 10 months ago (2014-01-30 11:13:14 UTC) #1

Toon Verwaest

6 years, 10 months ago (2014-01-30 11:30:48 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r18938 (presubmit successful).

Expand Messages | Collapse Messages