Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1010)

Issue 147763005: Allocation site pretenuring for StringAdd on all platforms. (Closed)

Created:
6 years, 10 months ago by Hannes Payer (out of office)
Modified:
6 years, 10 months ago
CC:
v8-dev
Visibility:
Public.

Description

Allocation site pretenuring for StringAdd on all platforms. BUG= R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18882

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Hannes Payer (out of office)
6 years, 10 months ago (2014-01-28 15:07:15 UTC) #1
mvstanton
That is very nice, so we only did it for ia32? lgtm.
6 years, 10 months ago (2014-01-28 15:23:32 UTC) #2
Hannes Payer (out of office)
Committed patchset #1 manually as r18882 (presubmit successful).
6 years, 10 months ago (2014-01-28 15:43:36 UTC) #3
Benedikt Meurer
6 years, 10 months ago (2014-01-28 18:49:52 UTC) #4
Message was sent while issue was closed.
LGTM, thanks. Got dropped during the rebase hell in december.

Powered by Google App Engine
This is Rietveld 408576698