Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: Source/bindings/v8/custom/V8CustomElementConstructorCustom.cpp

Issue 14776002: Create wrappers for unresolved Custom Elements at the correct type (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Use toV8 in the constructor. Remove unused variable. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/CustomElementHelpers.cpp ('k') | Source/core/dom/CustomElementRegistry.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/custom/V8CustomElementConstructorCustom.cpp
diff --git a/Source/bindings/v8/custom/V8CustomElementConstructorCustom.cpp b/Source/bindings/v8/custom/V8CustomElementConstructorCustom.cpp
index b693b6cb6cc99b11c17b63d9a863ea8ae1d788d6..4a82721b3e5a18fa9b61903fb63d6fd7fd3b3df3 100644
--- a/Source/bindings/v8/custom/V8CustomElementConstructorCustom.cpp
+++ b/Source/bindings/v8/custom/V8CustomElementConstructorCustom.cpp
@@ -32,6 +32,7 @@
#include "V8CustomElementConstructor.h"
+#include "V8Element.h"
#include "bindings/v8/CustomElementHelpers.h"
#include "bindings/v8/V8Binding.h"
#include "core/dom/CustomElementConstructor.h"
@@ -52,8 +53,8 @@ v8::Handle<v8::Value> V8CustomElementConstructor::callAsFunctionCallback(const v
setDOMException(ec, args.GetIsolate());
return v8Undefined();
}
- // FIXME: is args.Holder() the right creation context?
- return CustomElementHelpers::wrap(element.get(), args.Holder(), args.GetIsolate());
+
+ return toV8(element.get(), args.Holder(), args.GetIsolate());
}
} // namespace WebCore
« no previous file with comments | « Source/bindings/v8/CustomElementHelpers.cpp ('k') | Source/core/dom/CustomElementRegistry.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698