Create wrappers for unresolved Custom Elements at the correct type

Source/core/dom/Document.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
@@ skipping 758 matching lines @@
 
 PassRefPtr<Element> Document::createElement(const AtomicString& localName, const AtomicString& typeExtension, ExceptionCode& ec)
 {
     if (!isValidName(localName)) {
         ec = INVALID_CHARACTER_ERR;
         return 0;
     }
 
     RefPtr<Element> element;
 
-    if (m_registry)
-        element = m_registry->tryToCreateCustomTagElement(QualifiedName(nullAtom, localName, xhtmlNamespaceURI));
-
-    if (!element)
+    if (CustomElementRegistry::isCustomTagName(localName))
+        element = ensureCustomElementRegistry()->createCustomTagElement(QualifiedName(nullAtom, localName, xhtmlNamespaceURI));
+    else
         element = createElement(localName, ec);
 
     if (!typeExtension.isNull()) {
         setTypeExtension(element.get(), typeExtension);
-        if (m_registry)
-            m_registry->didGiveTypeExtension(element.get());
+        ensureCustomElementRegistry()->didGiveTypeExtension(element.get());
     }
 
     return element;
 }
 
 PassRefPtr<Element> Document::createElementNS(const AtomicString& namespaceURI, const String& qualifiedName, const AtomicString& typeExtension, ExceptionCode& ec)
 {
     String prefix, localName;
     if (!parseQualifiedName(qualifiedName, prefix, localName, ec))
         return 0;
 
     QualifiedName qName(prefix, localName, namespaceURI);
     if (!hasValidNamespaceForElements(qName)) {
         ec = NAMESPACE_ERR;
         return 0;
     }
 
     RefPtr<Element> element;
-
-    if (m_registry)
-        element = m_registry->tryToCreateCustomTagElement(qName);
-
-    if (!element)
+    if (CustomElementRegistry::isCustomTagName(qName.localName()))
+        element = ensureCustomElementRegistry()->createCustomTagElement(qName);
+    else
         element = createElementNS(namespaceURI, qualifiedName, ec);
 
     if (!typeExtension.isNull()) {
         setTypeExtension(element.get(), typeExtension);
-        if (m_registry)
-            m_registry->didGiveTypeExtension(element.get());
+        ensureCustomElementRegistry()->didGiveTypeExtension(element.get());
     }
 
     return element;
 }
 
 PassRefPtr<CustomElementConstructor> Document::registerElement(WebCore::ScriptState* state, const AtomicString& name, ExceptionCode& ec)
 {
     return registerElement(state, name, Dictionary(), ec);
 }
 
 PassRefPtr<CustomElementConstructor> Document::registerElement(WebCore::ScriptState* state, const AtomicString& name, const Dictionary& options, ExceptionCode& ec)
 {
     if (!isHTMLDocument() && !isXHTMLDocument()) {
         ec = NOT_SUPPORTED_ERR;
         return 0;
     }
 
-    if (!m_registry)
+    return ensureCustomElementRegistry()->registerElement(state, name, options, ec);
+}
+
+CustomElementRegistry* Document::ensureCustomElementRegistry()

[dglazkov, 2013/05/01 16:51:22]

Making registry RAII could've been its own patch, but I am okay with rolling
this up.

+{
+    if (!m_registry) {
+        ASSERT(isHTMLDocument() || isXHTMLDocument());
         m_registry = adoptRef(new CustomElementRegistry(this));
-    return m_registry->registerElement(state, name, options, ec);
+    }
+    return m_registry.get();
 }
 
 PassRefPtr<DocumentFragment> Document::createDocumentFragment()
 {
     return DocumentFragment::create(document());
 }
 
 PassRefPtr<Text> Document::createTextNode(const String& data)
 {
     return Text::create(this, data);
@@ skipping 4837 matching lines @@
         return;
 
     Vector<RefPtr<Element> > associatedFormControls;
     copyToVector(m_associatedFormControls, associatedFormControls);
 
     frame()->page()->chrome()->client()->didAssociateFormControls(associatedFormControls);
     m_associatedFormControls.clear();
 }
 
 } // namespace WebCore