Create wrappers for unresolved Custom Elements at the correct type

Source/core/dom/CustomElementRegistry.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 187 matching lines @@
     if (type.isNull())
         return 0;
     DefinitionMap::const_iterator it = m_definitions.find(type);
     if (it == m_definitions.end())
         return 0;
     if (it->value->namespaceURI() != namespaceURI)
         return 0;
     return it->value;
 }
 
-PassRefPtr<Element> CustomElementRegistry::tryToCreateCustomTagElement(const QualifiedName& tagName)
+PassRefPtr<Element> CustomElementRegistry::createCustomTagElement(const QualifiedName& tagName)
 {
-    if (!document() || !isValidName(tagName.localName()))
+    if (!document())
         return 0;
 
+    ASSERT(isCustomTagName(tagName.localName()));
+
     RefPtr<Element> element;
 
     if (HTMLNames::xhtmlNamespaceURI == tagName.namespaceURI())
         element = HTMLElement::create(tagName, document());
 #if ENABLE(SVG)
     else if (SVGNames::svgNamespaceURI == tagName.namespaceURI())
         element = SVGElement::create(tagName, document());
 #endif
     else
         element = Element::create(tagName, document());
 
     RefPtr<CustomElementDefinition> definition = findAndCheckNamespace(tagName.localName(), tagName.namespaceURI());
-    if (!definition || definition->isTypeExtension())
-        return 0;
+    if (definition && !definition->isTypeExtension())
+        didCreateCustomTagElement(element.get());
 
-    didCreateElement(element.get());
     return element.release();

[haraken, 2013/05/01 18:49:12]

This will change behavior. Previously 0 was returned when definition is 0. Is
this change OK?

[dominicc (has gone to gerrit), 2013/05/02 01:29:56]

Absolutely. That is what we're going for here, hence tryToCreateCustomTagElement
-> createCustomTagElement.

 }
 
 void CustomElementRegistry::didGiveTypeExtension(Element* element)
 {
     RefPtr<CustomElementDefinition> definition = findFor(element);
     if (!definition || !definition->isTypeExtension())
         return;
     activate(CustomElementInvocation(element));
 }
 
-void CustomElementRegistry::didCreateElement(Element* element)
+void CustomElementRegistry::didCreateCustomTagElement(Element* element)
 {
     activate(CustomElementInvocation(element));
 }
 
 void CustomElementRegistry::activate(const CustomElementInvocation& invocation)
 {
     bool wasInactive = m_invocations.isEmpty();
     m_invocations.append(invocation);
     if (wasInactive)
         activeCustomElementRegistries().add(this);
@@ skipping 30 matching lines @@
     while (!activeCustomElementRegistries().isEmpty()) {
         Vector<RefPtr<CustomElementRegistry> > registries;
         copyToVector(activeCustomElementRegistries(), registries);
         activeCustomElementRegistries().clear();
         for (size_t i = 0; i < registries.size(); ++i)
             registries[i]->deliverLifecycleCallbacks();
     }
 }
 
 }