Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(907)

Unified Diff: fpdfsdk/src/fpdfview_c_api_test.c

Issue 1477583002: Inflict PDF_ENABLE_XFA ifdefs on XFA fpdfsdk/ (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: fpdfsdk/src/fpdfview_c_api_test.c
diff --git a/fpdfsdk/src/fpdfview_c_api_test.c b/fpdfsdk/src/fpdfview_c_api_test.c
index 344b029ebaa2b73a888e86ec8c0ea56451481c8c..fdf83bec6df9fc115d1ee29a9a0b5ada757f0bdc 100644
--- a/fpdfsdk/src/fpdfview_c_api_test.c
+++ b/fpdfsdk/src/fpdfview_c_api_test.c
@@ -104,8 +104,10 @@ int CheckPDFiumCApi() {
CHK(FORM_OnMouseMove);
CHK(FORM_OnLButtonDown);
CHK(FORM_OnLButtonUp);
+#ifdef PDF_ENABLE_XFA
CHK(FORM_OnRButtonDown);
Lei Zhang 2015/11/25 00:34:31 I think this is dead code. Removal CL never got me
Tom Sepez 2015/11/25 21:45:30 I think this calls into xfa code now and is needed
CHK(FORM_OnRButtonUp);
+#endif
CHK(FORM_OnKeyDown);
CHK(FORM_OnKeyUp);
CHK(FORM_OnChar);
@@ -117,6 +119,7 @@ int CheckPDFiumCApi() {
CHK(FPDF_SetFormFieldHighlightAlpha);
CHK(FPDF_RemoveFormFieldHighlight);
CHK(FPDF_FFLDraw);
+#ifdef PDF_ENABLE_XFA
CHK(FPDF_HasXFAField);
CHK(FPDF_LoadXFA);
CHK(FPDF_Widget_Undo);
@@ -131,6 +134,7 @@ int CheckPDFiumCApi() {
CHK(FPDF_StringHandleGetStringByIndex);
CHK(FPDF_StringHandleRelease);
CHK(FPDF_StringHandleAddString);
+#endif
// fpdf_ppo.h
CHK(FPDF_ImportPages);
@@ -227,9 +231,11 @@ int CheckPDFiumCApi() {
CHK(FPDF_CountNamedDests);
CHK(FPDF_GetNamedDestByName);
CHK(FPDF_GetNamedDest);
+#ifdef PDF_ENABLE_XFA
CHK(FPDF_BStr_Init);
CHK(FPDF_BStr_Set);
CHK(FPDF_BStr_Clear);
+#endif
return 1;
}

Powered by Google App Engine
This is Rietveld 408576698