Issue 1477573002: Remove Field::FindFieldIndex() and update service protocol

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1477573002: Remove Field::FindFieldIndex() and update service protocol (Closed)

Created:
5 years ago by hausner

Modified:
5 years ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Remove Field::FindFieldIndex() and update service protocol This paves the way to remove functions and fields from top-level classes. They are looked up via the class dictionary when resolving names. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/e3457758ed7e2b24263bcbd9831cd764ce9fd110

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -101 lines)			Patch
M	runtime/observatory/tests/service/get_object_rpc_test.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/object.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	runtime/vm/object.cc	View	2 chunks	+7 lines, -44 lines	0 comments	Download
M	runtime/vm/object_test.cc	View	1 chunk	+0 lines, -48 lines	0 comments	Download
M	runtime/vm/service.cc	View	1 chunk	+7 lines, -5 lines	0 comments	Download

Total messages: 5 (2 generated)

hausner

5 years ago (2015-11-24 23:42:07 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e3457758ed7e2b24263bcbd9831cd764ce9fd110 (presubmit successful).