Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 1477553002: Issue 25034. Record only the target source's errors. (Closed)

Created:
5 years ago by scheglov
Modified:
5 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -15 lines) Patch
M pkg/analysis_server/test/analysis/get_errors_test.dart View 3 chunks +32 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 9 chunks +19 lines, -10 lines 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_test.dart View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years ago (2015-11-24 20:54:48 UTC) #1
Brian Wilkerson
LGTM
5 years ago (2015-11-24 21:42:30 UTC) #2
scheglov
5 years ago (2015-11-24 22:00:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cfb7d61a9cb6dd58d93f3d8e17a4831455a8d971 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698