Remove kint16max.

Remove kint16max.

BUG=138542
Committed: https://crrev.com/ab0f6cce01ee14d2d89ef556968fb07289975073
Cr-Commit-Position: refs/heads/master@{#361735}

[Avi (use Gerrit), 2015-11-24 20:27:08]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-24 20:29:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1477533002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1477533002/1

[commit-bot: I haz the power, 2015-11-24 21:22:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-24 21:22:23]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Avi (use Gerrit), 2015-11-24 21:29:30]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-24 21:29:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1477533002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1477533002/20001

[commit-bot: I haz the power, 2015-11-25 03:19:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-25 03:19:37]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2015-11-25 03:36:31]

avi@chromium.org changed reviewers:
+ cbentzel@chromium.org, dalecurtis@chromium.org, mark@chromium.org

[Avi (use Gerrit), 2015-11-25 03:36:31]

cbentzel@chromium.org: Please review changes in net/

mark@chromium.org: Please review changes in base/, ui/

dalecurtis@chromium.org: Please review changes in media/

[Mark Mentovai, 2015-11-25 05:03:53]

LGTM

[miu, 2015-11-25 05:36:26]

Sorry for the drive-by bike-shedding, but:

https://codereview.chromium.org/1477533002/diff/20001/media/cast/test/utility...
File media/cast/test/utility/generate_timecode_audio.cc (right):

https://codereview.chromium.org/1477533002/diff/20001/media/cast/test/utility...
media/cast/test/utility/generate_timecode_audio.cc:5: #include <stdint.h>
For consistency, please change this to:

  #include <cstdint>

(and move down three lines)

You'll probably want to do the same everywhere else in this change...

[Avi (use Gerrit), 2015-11-25 14:40:38]

https://codereview.chromium.org/1477533002/diff/20001/media/cast/test/utility...
File media/cast/test/utility/generate_timecode_audio.cc (right):

https://codereview.chromium.org/1477533002/diff/20001/media/cast/test/utility...
media/cast/test/utility/generate_timecode_audio.cc:5: #include <stdint.h>
I don't think this is a good idea.
http://stackoverflow.com/questions/13642827/cstdint-vs-stdint-h

Everywhere in Chromium we use stdint.h and non-std-qualified int types. If I
were to use cstdint, I would need to qualify with std:: all the int types (which
is done nowhere else in Chromium) or rely on cstdint putting the types in the
global namespace (which isn't guaranteed).

I'm going with maintaining consistency with the entire rest of the Chromium
codebase and using stdint.h.

[Mark Mentovai, 2015-11-25 14:44:44]

Don't use <cstdint> unless you intend to prefix the type names with std::. In
Chromium, we don't do this. It is correct to #include <stdint.h>, not <cstdint>.

[Avi (use Gerrit), 2015-11-25 15:16:58]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-25 15:17:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1477533002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1477533002/40001

[DaleCurtis, 2015-11-25 17:09:47]

media/ lgtm

[mmenke, 2015-11-25 17:34:08]

mmenke@chromium.org changed reviewers:
+ mmenke@chromium.org

[mmenke, 2015-11-25 17:34:09]

https://codereview.chromium.org/1477533002/diff/40001/net/disk_cache/blockfil...
File net/disk_cache/blockfile/block_files.cc (right):

https://codereview.chromium.org/1477533002/diff/40001/net/disk_cache/blockfil...
net/disk_cache/blockfile/block_files.cc:286: for (int16_t i = 0; i <
kFirstAdditionalBlockFile; i++) {
Hrm...It seems weird to use an int16_t with an int16 as the upper bound.

https://codereview.chromium.org/1477533002/diff/40001/net/disk_cache/blockfil...
net/disk_cache/blockfile/block_files.cc:464: header.this_file =
static_cast<int16_t>(index);
This seems kinda weird, since this_file is an int16.

https://codereview.chromium.org/1477533002/diff/40001/net/disk_cache/blockfil...
net/disk_cache/blockfile/block_files.cc:602: int16_t
BlockFiles::CreateNextBlockFile(FileType block_type) {
You need to modify the header, too.

https://codereview.chromium.org/1477533002/diff/40001/net/disk_cache/blockfil...
net/disk_cache/blockfile/block_files.cc:603: for (int16_t i =
kFirstAdditionalBlockFile; i <= kMaxBlockFile; i++) {
It seems weird to use an int16_t with an int16 as the upper bound.

[Avi (use Gerrit), 2015-11-25 17:56:18]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[Avi (use Gerrit), 2015-11-25 17:56:42]

I converted a few files with the definitions used in that one file.

https://codereview.chromium.org/1477533002/diff/40001/net/disk_cache/blockfil...
File net/disk_cache/blockfile/block_files.cc (right):

https://codereview.chromium.org/1477533002/diff/40001/net/disk_cache/blockfil...
net/disk_cache/blockfile/block_files.cc:464: header.this_file =
static_cast<int16_t>(index);
On 2015/11/25 17:34:09, mmenke wrote:
> This seems kinda weird, since this_file is an int16.

int16 is a typedef for int16_t. In eliminating kint16max I converted the whole
file at once, but didn't want to switch over the entire world. I can add a few
files if that makes you more comfortable.

[commit-bot: I haz the power, 2015-11-25 17:57:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1477533002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1477533002/60001

[commit-bot: I haz the power, 2015-11-25 18:13:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-25 18:13:12]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Avi (use Gerrit), 2015-11-25 18:24:31]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-25 18:25:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1477533002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1477533002/80001

[mmenke, 2015-11-25 18:37:10]

net/ LGTM

[miu, 2015-11-25 18:46:57]

On 2015/11/25 14:40:38, Avi wrote:
> media/cast/test/utility/generate_timecode_audio.cc:5: #include <stdint.h>
> I don't think this is a good idea.
> http://stackoverflow.com/questions/13642827/cstdint-vs-stdint-h
> 
> Everywhere in Chromium we use stdint.h and non-std-qualified int types. If I
> were to use cstdint, I would need to qualify with std:: all the int types
(which
> is done nowhere else in Chromium) or rely on cstdint putting the types in the
> global namespace (which isn't guaranteed).
> 
> I'm going with maintaining consistency with the entire rest of the Chromium
> codebase and using stdint.h.

Huh.  So it is.  :)  I've never yet come across an implementation that didn't
put the symbols in the global namespace, but it looks like stdint.h is the right
way to do that.  I'll change my approach.  Thanks.

[Avi (use Gerrit), 2015-11-25 19:58:16]

The CQ bit was unchecked by avi@chromium.org

[Avi (use Gerrit), 2015-11-25 19:58:27]

The CQ bit was checked by avi@chromium.org

[Avi (use Gerrit), 2015-11-25 19:58:28]

The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org,
dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/1477533002/#ps80001
(title: "includes")

[commit-bot: I haz the power, 2015-11-25 19:58:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1477533002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1477533002/80001

[commit-bot: I haz the power, 2015-11-25 21:02:04]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-11-25 21:02:48]

Description was changed from

==========
Remove kint16max.

BUG=138542
==========

to

==========
Remove kint16max.

BUG=138542

Committed: https://crrev.com/ab0f6cce01ee14d2d89ef556968fb07289975073
Cr-Commit-Position: refs/heads/master@{#361735}
==========

[commit-bot: I haz the power, 2015-11-25 21:02:49]

Patchset 5 (id:??) landed as
https://crrev.com/ab0f6cce01ee14d2d89ef556968fb07289975073
Cr-Commit-Position: refs/heads/master@{#361735}