Issue 14775002: Add LibraryDependencyMirror+CombinatorMirror to source mirrors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14775002: Add LibraryDependencyMirror+CombinatorMirror to source mirrors. (Closed)

Created:
7 years, 7 months ago by Johnni Winther

Modified:
7 years, 1 month ago

Reviewers:
Alan Knight

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add LibraryDependencyMirror+CombinatorMirror to source mirrors.

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+115 lines, -0 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart	View	2 chunks	+85 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/mirrors/mirrors.dart	View	1 chunk	+27 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/tree/nodes.dart	View	2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Alan Knight

Shouldn't these also be in the Mirror API in general? It's a significant lack there.

7 years, 7 months ago (2013-05-01 17:55:28 UTC) #1

Johnni Winther

7 years, 7 months ago (2013-05-01 17:57:34 UTC) #2

On 2013/05/01 17:55:28, Alan Knight wrote:
> Shouldn't these also be in the Mirror API in general? It's a significant lack
> there.

The source mirrors (in sdk/lib/_internal/compiler/implementation/mirrors/) is a
prototype for dart:mirrors. The two will merge before 1.0.

Expand Messages | Collapse Messages