[Chromecast] Allow media metrics events with no app running

chromecast/base/metrics/cast_metrics_helper.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromecast/base/metrics/cast_metrics_helper.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/location.h"
 #include "base/metrics/histogram.h"
@@ skipping 110 matching lines @@
   sdk_version_.clear();
 }
 
 void CastMetricsHelper::UpdateSDKInfo(const std::string& sdk_version) {
   MAKE_SURE_THREAD(UpdateSDKInfo, sdk_version);
   sdk_version_ = sdk_version;
 }
 
 void CastMetricsHelper::LogMediaPlay() {
   MAKE_SURE_THREAD(LogMediaPlay);
+  if (app_id_.empty())

[slan, 2015/11/25 01:22:25]

Did you consider setting a testing value for app_id_? That way we can follow
this codepath all the way down in our tests.

+    return;
   RecordSimpleAction(EncodeAppInfoIntoMetricsName(
       "MediaPlay",
       app_id_,
       session_id_,
       sdk_version_));
 }
 
 void CastMetricsHelper::LogMediaPause() {
   MAKE_SURE_THREAD(LogMediaPause);
+  if (app_id_.empty())
+    return;
   RecordSimpleAction(EncodeAppInfoIntoMetricsName(
       "MediaPause",
       app_id_,
       session_id_,
       sdk_version_));
 }
 
 void CastMetricsHelper::LogTimeToFirstPaint() {
   MAKE_SURE_THREAD(LogTimeToFirstPaint);
   if (app_id_.empty())
@@ skipping 116 matching lines @@
     const base::TimeDelta& value) {
   // Follow UMA_HISTOGRAM_MEDIUM_TIMES definition.
   LogTimeHistogramEvent(name, value,
                         base::TimeDelta::FromMilliseconds(10),
                         base::TimeDelta::FromMinutes(3),
                         50);
 }
 
 }  // namespace metrics
 }  // namespace chromecast