Remove unnecessary assert in LayoutSVGRoot

Remove unnecessary assert in LayoutSVGRoot

In LayoutSVGRoot::mapLocalToContainer we were asserting that the
transform mode was UseTransforms, an assertion that was violated when
the SVG layer was squashed into certain other layers. The assertion
has been commented out for more than a year.

Testing various configurations of transforms and SVG with squashing,
such that the assert would hit, reveals no changes in rendered behavior.
Code inspection suggests that the assertion is unnecessary because
there is no place where SVG code actually checks the mode (although
there are comments that indicate we assume it is set). Furthermore,
SVGLayoutSupport::mapLocalToContainer explicitly sets the mode to
UseTransforms.

Given the lack of impact on behavior and the absence of failures or
bugs since the assertion was disabled, this patch removes the
assertion entirely.

R=pdr
BUG=231541, 364901
Committed: https://crrev.com/1761ef2855918b3e54d974a7fa1a860d604d660f
Cr-Commit-Position: refs/heads/master@{#361703}

[Stephen Chennney, 2015-11-24 20:08:03]

The CQ bit was checked by schenney@chromium.org to run a CQ dry run

[Stephen Chennney, 2015-11-24 20:08:18]

I think it's time we lay this one to rest.

[commit-bot: I haz the power, 2015-11-24 20:08:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1477463003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1477463003/1

[commit-bot: I haz the power, 2015-11-24 21:29:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-24 21:29:37]

Dry run: This issue passed the CQ dry run.

[Stephen Chennney, 2015-11-24 22:08:20]

The CQ bit was checked by schenney@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-24 22:09:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1477463003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1477463003/20001

[pdr., 2015-11-24 22:09:53]

lgtm

[commit-bot: I haz the power, 2015-11-25 02:21:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-25 02:21:06]

Dry run: This issue passed the CQ dry run.

[Stephen Chennney, 2015-11-25 18:18:12]

The CQ bit was checked by schenney@chromium.org

[commit-bot: I haz the power, 2015-11-25 18:18:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1477463003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1477463003/20001

[commit-bot: I haz the power, 2015-11-25 18:27:20]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-25 18:28:43]

Description was changed from

==========
Remove unnecessary assert in LayoutSVGRoot

In LayoutSVGRoot::mapLocalToContainer we were asserting that the
transform mode was UseTransforms, an assertion that was violated when
the SVG layer was squashed into certain other layers. The assertion
has been commented out for more than a year.

Testing various configurations of transforms and SVG with squashing,
such that the assert would hit, reveals no changes in rendered behavior.
Code inspection suggests that the assertion is unnecessary because
there is no place where SVG code actually checks the mode (although
there are comments that indicate we assume it is set). Furthermore,
SVGLayoutSupport::mapLocalToContainer explicitly sets the mode to
UseTransforms.

Given the lack of impact on behavior and the absence of failures or
bugs since the assertion was disabled, this patch removes the
assertion entirely.

R=pdr
BUG=231541,364901
==========

to

==========
Remove unnecessary assert in LayoutSVGRoot

In LayoutSVGRoot::mapLocalToContainer we were asserting that the
transform mode was UseTransforms, an assertion that was violated when
the SVG layer was squashed into certain other layers. The assertion
has been commented out for more than a year.

Testing various configurations of transforms and SVG with squashing,
such that the assert would hit, reveals no changes in rendered behavior.
Code inspection suggests that the assertion is unnecessary because
there is no place where SVG code actually checks the mode (although
there are comments that indicate we assume it is set). Furthermore,
SVGLayoutSupport::mapLocalToContainer explicitly sets the mode to
UseTransforms.

Given the lack of impact on behavior and the absence of failures or
bugs since the assertion was disabled, this patch removes the
assertion entirely.

R=pdr
BUG=231541,364901

Committed: https://crrev.com/1761ef2855918b3e54d974a7fa1a860d604d660f
Cr-Commit-Position: refs/heads/master@{#361703}
==========

[commit-bot: I haz the power, 2015-11-25 18:28:44]

Patchset 2 (id:??) landed as
https://crrev.com/1761ef2855918b3e54d974a7fa1a860d604d660f
Cr-Commit-Position: refs/heads/master@{#361703}