Issue 1477433006: Re-order methods to make xfa diff saner

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1477433006: Re-order methods to make xfa diff saner (Closed)

Created:
5 years ago by Tom Sepez

Modified:
5 years ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Re-order methods to make xfa diff saner Precursor to making fpdf_text_int.cpp match cleanly. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/b210651db6a965ad50d726a4bb872580e93d2ae9

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -56 lines)			Patch
	M	core/src/fpdftext/fpdf_text_int.cpp	View		2 chunks	+56 lines, -56 lines	0 comments	Download

Total messages: 5 (2 generated)

Tom Sepez

5 years ago (2015-11-25 22:43:51 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b210651db6a965ad50d726a4bb872580e93d2ae9 (presubmit successful).