Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: src/compiler/raw-machine-assembler.cc

Issue 1477413002: Move RMA::Label out of the class, so it can be forward declared. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler/raw-machine-assembler.cc
diff --git a/src/compiler/raw-machine-assembler.cc b/src/compiler/raw-machine-assembler.cc
index d658c294d9bdcf28feef6d5a09b330b39d2da5ca..0570cc5947f3655527af3c8baa5d1fc08e494817 100644
--- a/src/compiler/raw-machine-assembler.cc
+++ b/src/compiler/raw-machine-assembler.cc
@@ -51,15 +51,15 @@ Node* RawMachineAssembler::Parameter(size_t index) {
}
-void RawMachineAssembler::Goto(Label* label) {
+void RawMachineAssembler::Goto(RawLabel* label) {
DCHECK(current_block_ != schedule()->end());
schedule()->AddGoto(CurrentBlock(), Use(label));
current_block_ = nullptr;
}
-void RawMachineAssembler::Branch(Node* condition, Label* true_val,
- Label* false_val) {
+void RawMachineAssembler::Branch(Node* condition, RawLabel* true_val,
+ RawLabel* false_val) {
DCHECK(current_block_ != schedule()->end());
Node* branch = AddNode(common()->Branch(), condition);
schedule()->AddBranch(CurrentBlock(), branch, Use(true_val), Use(false_val));
@@ -67,8 +67,8 @@ void RawMachineAssembler::Branch(Node* condition, Label* true_val,
}
-void RawMachineAssembler::Switch(Node* index, Label* default_label,
- int32_t* case_values, Label** case_labels,
+void RawMachineAssembler::Switch(Node* index, RawLabel* default_label,
+ int32_t* case_values, RawLabel** case_labels,
size_t case_count) {
DCHECK_NE(schedule()->end(), current_block_);
size_t succ_count = case_count + 1;
@@ -292,7 +292,7 @@ Node* RawMachineAssembler::CallCFunction8(
}
-void RawMachineAssembler::Bind(Label* label) {
+void RawMachineAssembler::Bind(RawLabel* label) {
DCHECK(current_block_ == nullptr);
DCHECK(!label->bound_);
label->bound_ = true;
@@ -300,13 +300,13 @@ void RawMachineAssembler::Bind(Label* label) {
}
-BasicBlock* RawMachineAssembler::Use(Label* label) {
+BasicBlock* RawMachineAssembler::Use(RawLabel* label) {
label->used_ = true;
return EnsureBlock(label);
}
-BasicBlock* RawMachineAssembler::EnsureBlock(Label* label) {
+BasicBlock* RawMachineAssembler::EnsureBlock(RawLabel* label) {
if (label->block_ == nullptr) label->block_ = schedule()->NewBasicBlock();
return label->block_;
}

Powered by Google App Engine
This is Rietveld 408576698