content/browser/renderer_host/media/video_capture_manager_unittest.cc - Issue 1477363002: Add logging of video device details on device open and close.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/media/video_capture_manager_unittest.cc

Issue 1477363002: Add logging of video device details on device open and close. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed VideoCaptureManagerTest.OpenNotExisting test. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/renderer_host/media/video_capture_manager_unittest.cc

diff --git a/content/browser/renderer_host/media/video_capture_manager_unittest.cc b/content/browser/renderer_host/media/video_capture_manager_unittest.cc

index ccfaafacf80edf75c05b84263448a63ec21e1151..87e723ac9a31fb8fd542bf083b77ec60cadd47ff 100644

--- a/content/browser/renderer_host/media/video_capture_manager_unittest.cc

+++ b/content/browser/renderer_host/media/video_capture_manager_unittest.cc

@@ -465,8 +465,8 @@ TEST_F(VideoCaptureManagerTest, OpenNotExisting) {

InSequence s;

EXPECT_CALL(*listener_, DevicesEnumerated(MEDIA_DEVICE_VIDEO_CAPTURE, _))

.WillOnce(SaveArg<1>(&devices));

- EXPECT_CALL(*listener_, Opened(MEDIA_DEVICE_VIDEO_CAPTURE, _));

EXPECT_CALL(*frame_observer_, OnError(_));

+ EXPECT_CALL(*listener_, Opened(MEDIA_DEVICE_VIDEO_CAPTURE, _));

nisse-chromium (ooo August 14) 2015/12/03 12:37:10 Not sure from when the Opened event is called, and

EXPECT_CALL(*listener_, Closed(MEDIA_DEVICE_VIDEO_CAPTURE, _));

vcm_->EnumerateDevices(MEDIA_DEVICE_VIDEO_CAPTURE);

« no previous file with comments | « content/browser/renderer_host/media/video_capture_manager.cc ('k') | no next file » | no next file with comments »