third_party/WebKit/Source/core/editing/Position.cpp - Issue 1477313003: Make SelectionEditor::setWithoutValidation() not to use obsoleted layout objects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/Position.cpp

Issue 1477313003: Make SelectionEditor::setWithoutValidation() not to use obsoleted layout objects (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: 2015-11-30T10:45:57 Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/editing/Position.cpp

diff --git a/third_party/WebKit/Source/core/editing/Position.cpp b/third_party/WebKit/Source/core/editing/Position.cpp

index 2f0f915aab6bff7b7b1cb2c646216923b742d4df..11f4d405afc432170a644f3e5ae4ec9c3052ae5e 100644

--- a/third_party/WebKit/Source/core/editing/Position.cpp

+++ b/third_party/WebKit/Source/core/editing/Position.cpp

@@ -289,7 +289,9 @@ int comparePositions(const PositionInComposedTree& positionA, const PositionInCo

ASSERT(positionA.isNotNull());

ASSERT(positionB.isNotNull());

+ positionA.anchorNode()->updateDistribution();

Node* containerA = positionA.computeContainerNode();

+ positionB.anchorNode()->updateDistribution();

Node* containerB = positionB.computeContainerNode();

int offsetA = positionA.computeOffsetInContainerNode();

int offsetB = positionB.computeOffsetInContainerNode();

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/SelectionEditor.h » ('j') | no next file with comments »