Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Side by Side Diff: third_party/WebKit/Source/core/editing/SelectionEditor.h

Issue 1477313003: Make SelectionEditor::setWithoutValidation() not to use obsoleted layout objects (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: 2015-11-30T10:45:57 Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 54
55 bool modify(EAlteration, SelectionDirection, TextGranularity, EUserTriggered ); 55 bool modify(EAlteration, SelectionDirection, TextGranularity, EUserTriggered );
56 bool modify(EAlteration, unsigned verticalDistance, VerticalDirection, EUser Triggered, CursorAlignOnScroll); 56 bool modify(EAlteration, unsigned verticalDistance, VerticalDirection, EUser Triggered, CursorAlignOnScroll);
57 57
58 template <typename Strategy> 58 template <typename Strategy>
59 const VisibleSelectionTemplate<Strategy>& visibleSelection() const; 59 const VisibleSelectionTemplate<Strategy>& visibleSelection() const;
60 void setVisibleSelection(const VisibleSelection&, FrameSelection::SetSelecti onOptions); 60 void setVisibleSelection(const VisibleSelection&, FrameSelection::SetSelecti onOptions);
61 void setVisibleSelection(const VisibleSelectionInComposedTree&, FrameSelecti on::SetSelectionOptions); 61 void setVisibleSelection(const VisibleSelectionInComposedTree&, FrameSelecti on::SetSelectionOptions);
62 62
63 void setIsDirectional(bool); 63 void setIsDirectional(bool);
64 void setWithoutValidation(const Position& start, const Position& end); 64 void setWithoutValidation(const Position& base, const Position& extent);
65 65
66 void resetXPosForVerticalArrowNavigation(); 66 void resetXPosForVerticalArrowNavigation();
67 67
68 void willBeModified(EAlteration, SelectionDirection); 68 void willBeModified(EAlteration, SelectionDirection);
69 69
70 // If this FrameSelection has a logical range which is still valid, this 70 // If this FrameSelection has a logical range which is still valid, this
71 // function return its clone. Otherwise, the return value from underlying 71 // function return its clone. Otherwise, the return value from underlying
72 // |VisibleSelection|'s |firstRange()| is returned. 72 // |VisibleSelection|'s |firstRange()| is returned.
73 PassRefPtrWillBeRawPtr<Range> firstRange() const; 73 PassRefPtrWillBeRawPtr<Range> firstRange() const;
74 74
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 // The range specified by the user, which may not be visually canonicalized 121 // The range specified by the user, which may not be visually canonicalized
122 // (hence "logical"). This will be invalidated if the underlying 122 // (hence "logical"). This will be invalidated if the underlying
123 // |VisibleSelection| changes. If that happens, this variable will 123 // |VisibleSelection| changes. If that happens, this variable will
124 // become |nullptr|, in which case logical positions == visible positions. 124 // become |nullptr|, in which case logical positions == visible positions.
125 RefPtrWillBeMember<Range> m_logicalRange; 125 RefPtrWillBeMember<Range> m_logicalRange;
126 }; 126 };
127 127
128 } // namespace blink 128 } // namespace blink
129 129
130 #endif // SelectionEditor_h 130 #endif // SelectionEditor_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/editing/Position.cpp ('k') | third_party/WebKit/Source/core/editing/SelectionEditor.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698