Remove ACCELERATED_OVERFLOW_SCROLLING as it is always off.

Remove ACCELERATED_OVERFLOW_SCROLLING as it is always off.

Remove all guards and the guarded code.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152278

[kbalazs_, 2013-05-28 16:19:50]

Cleanup: ACCELERATED_OVERFLOW_SCROLLING is not used in Blink, get rid of it.

[Stephen Chennney, 2013-05-28 16:33:48]

On 2013/05/28 16:19:50, kbalazs wrote:
> Cleanup: ACCELERATED_OVERFLOW_SCROLLING is not used in Blink, get rid of it.

Based on WebKit patches, this seems to be enabled for Android. Sami, is that
true?

[Sami, 2013-05-28 16:38:02]

On 2013/05/28 16:33:48, Stephen Chenney wrote:
> Based on WebKit patches, this seems to be enabled for Android. Sami, is that
> true?

Android has stopped defining this flag since we've moved to an automatic
heuristic that enables accelerated scrolling without requiring any special CSS
directives. So this is code is definitely dead.

[Stephen Chennney, 2013-05-28 16:41:21]

On 2013/05/28 16:38:02, Sami wrote:
> On 2013/05/28 16:33:48, Stephen Chenney wrote:
> > Based on WebKit patches, this seems to be enabled for Android. Sami, is that
> > true?
> 
> Android has stopped defining this flag since we've moved to an automatic
> heuristic that enables accelerated scrolling without requiring any special CSS
> directives. So this is code is definitely dead.

Great. So LGTM from me.

[commit-bot: I haz the power, 2013-05-28 16:41:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/b.kelemen@sisa.samsung.com/14773036/2001

[commit-bot: I haz the power, 2013-05-28 17:38:59]

Retried try job too often on linux_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layo...

[commit-bot: I haz the power, 2013-05-28 23:17:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/b.kelemen@sisa.samsung.com/14773036/2001

[commit-bot: I haz the power, 2013-05-29 02:06:08]

Retried try job too often on win_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...

[commit-bot: I haz the power, 2013-05-30 18:49:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/b.kelemen@sisa.samsung.com/14773036/2001

[commit-bot: I haz the power, 2013-05-30 18:49:44]

Failed to apply patch for Source/core/rendering/RenderLayer.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/rendering/RenderLayer.cpp
  Hunk #1 FAILED at 2055.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/rendering/RenderLayer.cpp.rej

Patch:       Source/core/rendering/RenderLayer.cpp
Index: Source/core/rendering/RenderLayer.cpp
diff --git a/Source/core/rendering/RenderLayer.cpp
b/Source/core/rendering/RenderLayer.cpp
index
6fd7c24921906d5ed4687b8b90ae673073959d90..36be713a7578823d79c5412aae79b7164053c992
100644
--- a/Source/core/rendering/RenderLayer.cpp
+++ b/Source/core/rendering/RenderLayer.cpp
@@ -2055,15 +2055,8 @@ void RenderLayer::updateNeedsCompositedScrolling()
     if (frameView && frameView->containsScrollableArea(this)) {
         updateDescendantDependentFlags();
 
-        bool forceUseCompositedScrolling =
acceleratedCompositingForOverflowScrollEnabled()
-            && canBeStackingContainer()
-            && !hasOutOfFlowPositionedDescendant();
-
-#if ENABLE(ACCELERATED_OVERFLOW_SCROLLING)
-        needsCompositedScrolling = forceUseCompositedScrolling ||
renderer()->style()->useTouchOverflowScrolling();
-#else
-        needsCompositedScrolling = forceUseCompositedScrolling;
-#endif
+        needsCompositedScrolling =
acceleratedCompositingForOverflowScrollEnabled() && canBeStackingContainer() &&
!hasOutOfFlowPositionedDescendant();
+
         // We gather a boolean value for use with Google UMA histograms to
         // quantify the actual effects of a set of patches attempting to
         // relax composited scrolling requirements, thereby increasing the

[commit-bot: I haz the power, 2013-05-31 10:09:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/b.kelemen@sisa.samsung.com/14773036/27001

[commit-bot: I haz the power, 2013-05-31 12:10:30]

Retried try job too often on win_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...

[commit-bot: I haz the power, 2013-06-11 16:10:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/b.kelemen@sisa.samsung.com/14773036/27001

[commit-bot: I haz the power, 2013-06-11 16:10:33]

Failed to apply patch for Source/core/css/resolver/StyleResolver.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/css/resolver/StyleResolver.cpp
  Hunk #1 succeeded at 1594 (offset 8 lines).
  Hunk #2 FAILED at 2829.
  1 out of 2 hunks FAILED -- saving rejects to file
Source/core/css/resolver/StyleResolver.cpp.rej

Patch:       Source/core/css/resolver/StyleResolver.cpp
Index: Source/core/css/resolver/StyleResolver.cpp
diff --git a/Source/core/css/resolver/StyleResolver.cpp
b/Source/core/css/resolver/StyleResolver.cpp
index
2216bae31b28effd064782d13f7ea4033d271d0f..a12fda83e61b2a9c417afae32019214d0e183e5e
100644
--- a/Source/core/css/resolver/StyleResolver.cpp
+++ b/Source/core/css/resolver/StyleResolver.cpp
@@ -1586,10 +1586,6 @@ void StyleResolver::adjustRenderStyle(RenderStyle* style,
RenderStyle* parentSty
         || style->hasBlendMode()
         || style->position() == StickyPosition
         || (style->position() == FixedPosition && e && e->document()->page() &&
e->document()->page()->settings()->fixedPositionCreatesStackingContext())
-#if ENABLE(ACCELERATED_OVERFLOW_SCROLLING)
-        // Touch overflow scrolling creates a stacking context.
-        || ((style->overflowX() != OHIDDEN || style->overflowY() != OHIDDEN) &&
style->useTouchOverflowScrolling())
-#endif
         || (e && e->isInTopLayer())
         ))
         style->setZIndex(0);
@@ -2833,15 +2829,6 @@ void StyleResolver::applyProperty(CSSPropertyID id,
CSSValue* value)
         state.style()->setTapHighlightColor(col);
         return;
     }
-#if ENABLE(ACCELERATED_OVERFLOW_SCROLLING)
-    case CSSPropertyWebkitOverflowScrolling: {
-        HANDLE_INHERIT_AND_INITIAL(useTouchOverflowScrolling,
UseTouchOverflowScrolling);
-        if (!primitiveValue)
-            break;
-        state.style()->setUseTouchOverflowScrolling(primitiveValue->getIdent()
== CSSValueTouch);
-        return;
-    }
-#endif
     case CSSPropertyInvalid:
         return;
     // Directional properties are resolved by resolveDirectionAwareProperty()
before the switch.

[commit-bot: I haz the power, 2013-06-12 10:17:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/b.kelemen@sisa.samsung.com/14773036/41001

[commit-bot: I haz the power, 2013-06-12 11:59:49]

Change committed as 152278