Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Unified Diff: trunk/src/content/renderer/memory_benchmarking_extension.cc

Issue 14773032: Revert 182659 "Get a filename of dumped heap profile in a V8 ext..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | trunk/src/third_party/tcmalloc/chromium/src/gperftools/heap-profiler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/content/renderer/memory_benchmarking_extension.cc
===================================================================
--- trunk/src/content/renderer/memory_benchmarking_extension.cc (revision 200239)
+++ trunk/src/content/renderer/memory_benchmarking_extension.cc (working copy)
@@ -35,7 +35,7 @@
"};"
"chrome.memoryBenchmarking.heapProfilerDump = function(reason) {"
" native function HeapProfilerDump();"
- " return HeapProfilerDump(reason);"
+ " HeapProfilerDump(reason);"
"};"
) {}
@@ -60,14 +60,10 @@
static v8::Handle<v8::Value> HeapProfilerDump(const v8::Arguments& args) {
#if !defined(NO_TCMALLOC) && defined(OS_LINUX)
- char dumped_filename_buffer[1000];
std::string reason("benchmarking_extension");
if (args.Length() && args[0]->IsString())
reason = *v8::String::AsciiValue(args[0]);
- ::HeapProfilerDumpWithFileName(reason.c_str(),
- dumped_filename_buffer,
- sizeof(dumped_filename_buffer));
- return v8::String::New(dumped_filename_buffer);
+ ::HeapProfilerDump(reason.c_str());
#endif // !defined(NO_TCMALLOC) && defined(OS_LINUX)
return v8::Undefined();
}
« no previous file with comments | « no previous file | trunk/src/third_party/tcmalloc/chromium/src/gperftools/heap-profiler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698